starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-21 08:03:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(datatable-migrations): serialize run/rollback with a per-db advisory lock

Browse Source 
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Diego Imbert
2026-07-03 17:41:19 +02:00
co-authored by Claude Opus 4.8
parent 12b682ef13
commit 91021816e7
1 changed files with 22 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-api-workspaces/src/datatable_migrations.rs
+22
View File
@@ -274,6 +274,17 @@ async fn run_datatable_migrations(
}
});
// Serialize concurrent migration runs/rollbacks against this data table's
// database. Without it two "Run all" requests (or a run racing a rollback)
// read the same `_wm_migrations` state and launch the same DDL twice, which
// errors or corrupts a non-idempotent migration. This session-level lock is
// held for the whole operation and released when the connection drops at
// return; `_wm_migrations` is per-database, so a single key is sufficient.
client
.batch_execute("SELECT pg_advisory_lock(hashtext('windmill_datatable_migrations')::int8)")
.await
.map_err(|e| Error::internal_err(format!("Failed to acquire migration lock: {}", e)))?;
client
.batch_execute(
"CREATE TABLE IF NOT EXISTS _wm_migrations (\
@@ -382,6 +393,17 @@ async fn rollback_datatable_migrations(
}
});
// Serialize concurrent migration runs/rollbacks against this data table's
// database. Without it two "Run all" requests (or a run racing a rollback)
// read the same `_wm_migrations` state and launch the same DDL twice, which
// errors or corrupts a non-idempotent migration. This session-level lock is
// held for the whole operation and released when the connection drops at
// return; `_wm_migrations` is per-database, so a single key is sufficient.
client
.batch_execute("SELECT pg_advisory_lock(hashtext('windmill_datatable_migrations')::int8)")
.await
.map_err(|e| Error::internal_err(format!("Failed to acquire migration lock: {}", e)))?;
client
.batch_execute(
"CREATE TABLE IF NOT EXISTS _wm_migrations (\