starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-28 08:02:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: update the local draft markers for drafts a move transfers

Browse Source 
The transfer bypasses the syncer that keeps localDraftHints, and lists
prefer a hint over the server's flag, so the parent kept its markers after
"Remove these drafts". The parent's hints are cleared for removed drafts
and the fork's set for copied ones.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Guilhem Lemouel
2026-10-27 02:36:06 -07:00
co-authored by Claude Opus 5.5
parent e555a2a79f
commit 9e8eb53f22
1 changed files with 11 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/sessions/moveSessionToFork.ts
+11 -6
View File
@@ -3,6 +3,7 @@ import { DraftService, type DraftItemRef } from '$lib/gen'
import { UserDraft } from '$lib/userDraft.svelte'
import { UserDraftDbSyncer } from '$lib/userDraftDbSyncer.svelte'
import { invalidateWorkspaceDrafts } from '$lib/workspaceDrafts.svelte'
import { setLocalDraftHint } from '$lib/localDraftHints.svelte'
import { invalidateWorkspaceDiffCache } from '$lib/components/copilot/chat/global/diffSnapshot'
import { logFeatureUsage } from '$lib/utils/featureUsage'
import {
@@ -139,8 +140,8 @@ export async function moveSessionToFork(
if (opts.isBusy?.()) return { ok: false, error: busy, retry: fork }
}
let copied = 0
let removed = 0
let copied: DraftItemRef[] = []
let removed: DraftItemRef[] = []
if (opts.items.length > 0) {
try {
const res = await DraftService.transferDrafts({
@@ -160,16 +161,20 @@ export async function moveSessionToFork(
retry: fork
}
}
copied = res.copied.length
removed = res.removed.length
copied = res.copied
removed = res.removed
} catch (e: any) {
return { ok: false, error: String(e?.body ?? e?.message ?? e), retry: fork }
}
}
if (removed > 0) {
if (removed.length > 0) {
for (const it of opts.items) UserDraft.forgetLocal(it.kind, it.path, { workspace: parent })
}
// The transfer bypasses the syncer that keeps these hints, and lists prefer a hint over the
// server's flag, so a refetch alone would keep the parent's markers.
for (const it of removed) setLocalDraftHint(parent, it.kind, it.path, false)
for (const it of copied) setLocalDraftHint(fork.id, it.kind, it.path, true)
await reloadOpenEditors(fork.id, opts.items)
await moveSessionToWorkspace(sessionId, fork.id)
for (const ws of [parent, fork.id]) {
@@ -181,5 +186,5 @@ export async function moveSessionToFork(
entityId: sessionId,
workspace: fork.id
})
return { ok: true, forkId: fork.id, copied, removed }
return { ok: true, forkId: fork.id, copied: copied.length, removed: removed.length }
}