starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-21 00:02:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: key the audit operation index on id with a trailing timestamp

Browse Source 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-09-18 19:38:41 +02:00
co-authored by Claude Opus 5
parent 8ce6ed722f
commit 9ed483ae70
4 changed files with 15 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/migrations/20260918062854_audit_partitioned_workspace_operation_index.up.sql
-4
View File
@@ -1,4 +0,0 @@
-- The backend builds this per partition with CREATE INDEX CONCURRENTLY instead,
-- see create_audit_operation_index_concurrently in windmill-api/src/db.rs
CREATE INDEX IF NOT EXISTS ix_audit_partitioned_workspace_operation
ON audit_partitioned (workspace_id, operation, "timestamp" DESC);
backend/migrations/20260918062854_audit_partitioned_workspace_operation_index.down.sql → backend/migrations/20260918173412_audit_partitioned_workspace_operation_index.down.sql
View File
backend/migrations/20260918173412_audit_partitioned_workspace_operation_index.up.sql
+6
View File
@@ -0,0 +1,6 @@
-- The backend builds this per partition with CREATE INDEX CONCURRENTLY instead,
-- see create_audit_operation_index_concurrently in windmill-api/src/db.rs.
-- id matches list_audit's order and before_id cursor. timestamp trails it so a
-- time window is checked in the index rather than on every row it reads.
CREATE INDEX IF NOT EXISTS ix_audit_partitioned_workspace_operation
ON audit_partitioned (workspace_id, operation, id DESC, "timestamp");
backend/windmill-api/src/db.rs
+9 -5
View File
@@ -30,7 +30,8 @@ async fn current_database(conn: &mut PgConnection) -> Result<String, MigrateErro
.await?)
}
const AUDIT_OPERATION_INDEX_MIGRATION: i64 = 20260918062854;
const AUDIT_OPERATION_INDEX_MIGRATION: i64 = 20260918173412;
const AUDIT_OPERATION_INDEX_KEY: &str = r#"(workspace_id, operation, id DESC, "timestamp")"#;
/// A plain `CREATE INDEX` on the partitioned table holds a SHARE lock on every partition until the
/// whole build ends, blocking the audit insert each job push makes in its own transaction. Each
@@ -40,8 +41,11 @@ async fn create_audit_operation_index_concurrently(
conn: &mut PgConnection,
) -> Result<(), MigrateError> {
conn.execute(
r#"CREATE INDEX IF NOT EXISTS ix_audit_partitioned_workspace_operation
ON ONLY audit_partitioned (workspace_id, operation, "timestamp" DESC)"#,
format!(
"CREATE INDEX IF NOT EXISTS ix_audit_partitioned_workspace_operation \
ON ONLY audit_partitioned {AUDIT_OPERATION_INDEX_KEY}"
)
.as_str(),
)
.await?;
let partitions: Vec<String> = sqlx::query_scalar(
@@ -57,14 +61,14 @@ async fn create_audit_operation_index_concurrently(
.await?;
let quote = |name: &str| format!("\"{}\"", name.replace('"', "\"\""));
for partition in partitions {
let index = quote(&format!("{partition}_workspace_id_operation_timestamp_idx"));
let index = quote(&format!("{partition}_workspace_id_operation_id_timestamp_idx"));
tracing::info!("Building ix_audit_partitioned_workspace_operation on {partition}");
// An interrupted CONCURRENTLY build leaves an invalid index under this name.
conn.execute(format!("DROP INDEX CONCURRENTLY IF EXISTS {index}").as_str())
.await?;
conn.execute(
format!(
r#"CREATE INDEX CONCURRENTLY {index} ON {} (workspace_id, operation, "timestamp" DESC)"#,
"CREATE INDEX CONCURRENTLY {index} ON {} {AUDIT_OPERATION_INDEX_KEY}",
quote(&partition)
)
.as_str(),