mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-08-19 00:02:03 +00:00
fix(frontend): fix full screen mode of the EvalInputEditor (#3928)
* update datafusion * fix(frontend): fix full screen mode of the EvalInputEditor * fix(frontend): improve code --------- Co-authored-by: Ruben Fiszel <ruben@rubenfiszel.com>
This commit is contained in:
+7
-1
@@ -10,6 +10,7 @@
|
||||
import { Drawer } from '$lib/components/common'
|
||||
import { Pane, Splitpanes } from 'svelte-splitpanes'
|
||||
import Toggle from '$lib/components/Toggle.svelte'
|
||||
import { zIndexes } from '$lib/zIndexes'
|
||||
|
||||
export let componentInput: EvalV2AppInput | undefined
|
||||
export let id: string
|
||||
@@ -56,7 +57,12 @@
|
||||
|
||||
{#if componentInput?.type === 'evalv2'}
|
||||
{#if fullscreen}
|
||||
<Drawer placement="bottom" on:close={() => (fullscreen = false)} open>
|
||||
<Drawer
|
||||
placement="bottom"
|
||||
on:close={() => (fullscreen = false)}
|
||||
open
|
||||
offset={zIndexes.monacoEditor}
|
||||
>
|
||||
<Splitpanes horizontal class="h-full">
|
||||
<Pane size={50}>
|
||||
<SimpleEditor
|
||||
|
||||
@@ -14,7 +14,9 @@
|
||||
openedDrawers.push(id)
|
||||
}
|
||||
|
||||
let offset = 0
|
||||
export let initialOffset = 0
|
||||
|
||||
let offset = initialOffset
|
||||
|
||||
export function toggleDrawer() {
|
||||
if (!open) {
|
||||
@@ -37,7 +39,7 @@
|
||||
|
||||
export function closeDrawer() {
|
||||
open = false
|
||||
offset = 0
|
||||
offset = initialOffset
|
||||
// remove the last opened drawer
|
||||
openedDrawers = openedDrawers.filter((drawer) => drawer !== id)
|
||||
}
|
||||
|
||||
@@ -10,6 +10,7 @@
|
||||
export let size = '600px'
|
||||
export let alwaysOpen = false
|
||||
export let shouldUsePortal: boolean = true
|
||||
export let offset: number = 0
|
||||
|
||||
let disposable: Disposable | undefined = undefined
|
||||
|
||||
@@ -62,7 +63,15 @@
|
||||
</script>
|
||||
|
||||
<ConditionalPortal condition={shouldUsePortal}>
|
||||
<Disposable let:handleClickAway let:zIndex bind:open bind:this={disposable} on:open on:close>
|
||||
<Disposable
|
||||
initialOffset={offset}
|
||||
let:handleClickAway
|
||||
let:zIndex
|
||||
bind:open
|
||||
bind:this={disposable}
|
||||
on:open
|
||||
on:close
|
||||
>
|
||||
<aside
|
||||
class="drawer {$$props.class ?? ''} {$$props.positionClass ?? ''}"
|
||||
class:open
|
||||
|
||||
Reference in New Issue
Block a user