make the packaged components resolvable by consumers (#11682)

* fix: make the packaged components resolvable by consumers

The svelte-package output of @windmill-labs/components imported the chat
SDK from outside the package root, pointed `$lib/utils` at a directory
with no index, and shipped an `import.meta.glob` on the `$lib` alias.
Bundle the chat SDK entry point into the package, repair the directory
specifier, make the glob relative, and fail packaging on any import a
consumer cannot resolve.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

* fix: pin the chat sdk output root and widen the packaging checks

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-10-12 10:47:52 +02:00
committed by GitHub
co-authored by Claude Opus 5.5
parent 478eef7352
commit b347e792f8
2 changed files with 78 additions and 4 deletions
+74 -3
View File
@@ -16,9 +16,22 @@
// tarball. Copy the registry into the package and rewrite those imports
// to point at it (mirrors how package-system-prompts.js bundles
// `$system_prompts`).
//
// 3. Chat SDK: the `windmill-chat` alias (svelte.config.js) points at
// `chat-sdk/src/index.ts`, which escapes the package root the same way.
// Compile that entry point into the package and rewrite those imports.
//
// 4. `$lib/utils` from inside `utils/`: svelte-package turns it into `./`,
// which is the `utils/` directory (no index) rather than `utils.js`.
// Point a directory specifier with no index at its sibling module.
//
// A relative import that still escapes the package root, or an
// `import.meta.glob` left on an alias, fails the build: either one
// publishes fine and only breaks in the consumer's bundler.
import { execFileSync } from 'child_process'
import { copyFileSync, existsSync, readdirSync, readFileSync, statSync, writeFileSync } from 'fs'
import { fileURLToPath } from 'url'
import { dirname, join, relative, resolve } from 'path'
import { dirname, join, relative, resolve, sep } from 'path'
const __filename = fileURLToPath(import.meta.url)
const __dirname = dirname(__filename)
@@ -29,8 +42,37 @@ const oauthConnectDest = join(packageDir, 'oauth_connect.json')
copyFileSync(oauthConnectSrc, oauthConnectDest)
const IMPORT_SPECIFIER_RE = /(\bfrom\s*|\bimport\s*\(?\s*)(['"])(\.\.?\/[^'"]*\.(?:svelte|json))\2/g
const chatSdkSrc = resolve(__dirname, '..', '..', 'chat-sdk', 'src', 'index.ts')
const chatSdkDest = join(packageDir, 'chat-sdk')
// File arguments make tsc ignore every tsconfig and emit only what the entry
// point reaches, which leaves out the React and AI SDK adapters.
execFileSync(
'npx',
[
'tsc',
chatSdkSrc,
'--outDir',
chatSdkDest,
'--rootDir',
dirname(chatSdkSrc),
'--declaration',
'--target',
'ES2021',
'--module',
'ESNext',
'--moduleResolution',
'bundler',
'--skipLibCheck'
],
{ stdio: 'inherit', cwd: resolve(__dirname, '..') }
)
const IMPORT_SPECIFIER_RE = /(\bfrom\s*|\bimport\s*\(?\s*)(['"])(\.\.?(?:\/[^'"]*)?)\2/g
const OAUTH_CONNECT_RE = /^(\.\.\/)+backend\/oauth_connect\.json$/
const CHAT_SDK_RE = /^(\.\.\/)+chat-sdk\/src\/index\.ts$/
const DIRECTORY_RE = /(^|\/)\.\.?$|\/$/
const ALIASED_GLOB_RE = /import\.meta\.glob(?:<[^>]*>)?\(\s*\[?\s*['"]\$/
function* walk(dir) {
for (const entry of readdirSync(dir)) {
@@ -50,9 +92,13 @@ function relativeSpecifier(fromFile, toFile) {
let rewrittenFiles = 0
let rewrittenImports = 0
const unresolvable = []
for (const file of walk(packageDir)) {
const content = readFileSync(file, 'utf-8')
if (ALIASED_GLOB_RE.test(content)) {
unresolvable.push(`${relative(packageDir, file)}: import.meta.glob on an alias`)
}
let changed = false
const updated = content.replace(IMPORT_SPECIFIER_RE, (match, prefix, quote, specifier) => {
if (OAUTH_CONNECT_RE.test(specifier)) {
@@ -60,10 +106,27 @@ for (const file of walk(packageDir)) {
rewrittenImports++
return `${prefix}${quote}${relativeSpecifier(file, oauthConnectDest)}${quote}`
}
if (CHAT_SDK_RE.test(specifier)) {
changed = true
rewrittenImports++
return `${prefix}${quote}${relativeSpecifier(file, join(chatSdkDest, 'index.js'))}${quote}`
}
const target = resolve(dirname(file), specifier)
if (target !== packageDir && !target.startsWith(packageDir + sep)) {
unresolvable.push(`${relative(packageDir, file)}: ${specifier}`)
return match
}
if (DIRECTORY_RE.test(specifier)) {
if (!existsSync(join(target, 'index.js')) && existsSync(target + '.js')) {
changed = true
rewrittenImports++
return `${prefix}${quote}${relativeSpecifier(file, target + '.js')}${quote}`
}
return match
}
if (!specifier.endsWith('.svelte')) {
return match
}
const target = resolve(dirname(file), specifier)
// A real `.svelte` component file: leave the import alone.
if (existsSync(target)) {
return match
@@ -82,6 +145,14 @@ for (const file of walk(packageDir)) {
}
}
if (unresolvable.length > 0) {
console.error(
`fix-svelte-module-imports: ${unresolvable.length} import(s) a consumer cannot resolve:\n` +
unresolvable.join('\n')
)
process.exit(1)
}
console.log(
`fix-svelte-module-imports: rewrote ${rewrittenImports} import(s) in ${rewrittenFiles} file(s)`
)
@@ -12,8 +12,11 @@ import { findMcpEntry, findMcpEntryByUrl } from './registry'
* the chat does not otherwise reach that barrel. `import.meta.glob` gives the
* filenames at build time and the module only when a match is actually used, so
* a workspace with two connections downloads two icons.
*
* The pattern is relative because svelte-package rewrites `$lib` only in import
* specifiers: an aliased glob ships as-is and no consumer's bundler expands it.
*/
const iconModules = import.meta.glob('$lib/components/icons/*.svelte') as Record<
const iconModules = import.meta.glob('../icons/*.svelte') as Record<
string,
() => Promise<{ default: Component<any> }>
>