starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-04 16:03:06 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: parse flow value only if needed (#7025)

Browse Source 
* nits

* renames
This commit is contained in:
dieriba
2025-11-01 15:08:34 +01:00
committed by GitHub
parent f661caf2b1
commit b5e341fde7
2 changed files with 11 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-api/src/flows.rs
+1 -1
View File
@@ -1365,8 +1365,8 @@ async fn archive_flow_by_path(
/// Validates that flow debouncing configuration is supported by all workers
/// Returns an error if debouncing is configured but workers are behind required version
async fn guard_flow_from_debounce_data(nf: &NewFlow) -> Result<()> {
let flow_value = nf.parse_flow_value()?;
if !*MIN_VERSION_SUPPORTS_DEBOUNCING.read().await && {
let flow_value = nf.parse_flow_value()?;
flow_value.debounce_key.is_some() || flow_value.debounce_delay_s.is_some()
} {
tracing::warn!(
backend/windmill-common/src/flows.rs
+10 -10
View File
@@ -112,7 +112,7 @@ where
let flow_value: FlowValue = serde_json::from_str(raw_value.get())
.map_err(|e| serde::de::Error::custom(format!("Invalid flow value: {}", e)))?;
FlowModule::traverse_leafs(&flow_value.modules, &mut |module| {
FlowModule::traverse_modules(&flow_value.modules, &mut |module| {
if let Some(ref retry) = module.retry {
validate_retry(retry, &module.id)?;
}
@@ -544,7 +544,7 @@ impl FlowModule {
.map(|x| x.r#type)
}
pub fn traverse_leafs<C: FnMut(&FlowModule) -> crate::error::Result<()>>(
pub fn traverse_modules<C: FnMut(&FlowModule) -> crate::error::Result<()>>(
modules: &Vec<FlowModule>,
cb: &mut C,
) -> crate::error::Result<()> {
@@ -556,17 +556,17 @@ impl FlowModule {
{
FlowModuleValue::ForloopFlow { modules, .. }
| FlowModuleValue::WhileloopFlow { modules, .. } => {
Self::traverse_leafs(&modules, cb)?;
Self::traverse_modules(&modules, cb)?;
}
FlowModuleValue::BranchOne { branches, default, .. } => {
for branch in branches {
Self::traverse_leafs(&branch.modules, cb)?;
Self::traverse_modules(&branch.modules, cb)?;
}
Self::traverse_leafs(&default, cb)?;
Self::traverse_modules(&default, cb)?;
}
FlowModuleValue::BranchAll { branches, .. } => {
for branch in branches {
Self::traverse_leafs(&branch.modules, cb)?;
Self::traverse_modules(&branch.modules, cb)?;
}
}
FlowModuleValue::AIAgent { tools, .. } => {
@@ -575,17 +575,17 @@ impl FlowModule {
ToolValue::FlowModule(module_value) => match module_value {
FlowModuleValue::ForloopFlow { modules, .. }
| FlowModuleValue::WhileloopFlow { modules, .. } => {
Self::traverse_leafs(&modules, cb)?;
Self::traverse_modules(&modules, cb)?;
}
FlowModuleValue::BranchOne { branches, default, .. } => {
for branch in branches {
Self::traverse_leafs(&branch.modules, cb)?;
Self::traverse_modules(&branch.modules, cb)?;
}
Self::traverse_leafs(&default, cb)?;
Self::traverse_modules(&default, cb)?;
}
FlowModuleValue::BranchAll { branches, .. } => {
for branch in branches {
Self::traverse_leafs(&branch.modules, cb)?;
Self::traverse_modules(&branch.modules, cb)?;
}
}
_ => {}