starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-21 00:02:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: keep sidebar confirmation dialogs from being confined to the rail (#11158)

Browse Source 
Co-authored-by: Claude Fable 5.1 <noreply@anthropic.com>
This commit is contained in:
Guilhem
2026-09-16 10:42:47 +02:00
committed by GitHub
co-authored by Claude Fable 5.1
parent e8078f2a96
commit b9b5988ebd
5 changed files with 18 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/home/ItemsList.svelte
+4 -1
View File
@@ -2107,8 +2107,11 @@
}
}
/* `backwards`, not `both`: the fill hides rows until their staggered start, but a forwards
fill would keep `transform` animated afterwards and confine the row's remove confirmation
(`position: fixed`) to the row. The `to` keyframe equals the row's resting style. */
.wm-imported > :global(*) {
animation: wm-row-in 260ms ease-out both;
animation: wm-row-in 260ms ease-out backwards;
animation-delay: 320ms;
}
.wm-imported > :global(*:nth-child(1)) {
frontend/src/lib/components/sidebar/DeleteForkedWorkspaceModal.svelte
+3
View File
@@ -151,8 +151,11 @@
</script>
{#if currentWsIsFork}
<!-- `alwaysPortal`: this sits in the sidebar, whose mobile slide-in panel keeps a `transform`
that would otherwise confine the dialog to the panel's width. -->
<ConfirmationModal
{open}
alwaysPortal
title="Delete forked workspace"
confirmationText="Remove"
on:canceled={() => {
frontend/src/lib/components/sidebar/SettingsMenu.svelte
+3
View File
@@ -396,8 +396,11 @@
{/snippet}
</DropdownV2>
<!-- `alwaysPortal`: the sidebar's mobile slide-in panel keeps a `transform` that would
otherwise confine the dialog to the panel's width. -->
<ConfirmationModal
open={leaveWorkspaceModal}
alwaysPortal
title="Leave workspace"
confirmationText="Leave workspace"
on:canceled={() => {
frontend/src/lib/components/sidebar/SidebarContent.svelte
+3
View File
@@ -737,8 +737,11 @@
</div></nav
>
<!-- `alwaysPortal`: the sidebar's mobile slide-in panel keeps a `transform` that would
otherwise confine the dialog to the panel's width. -->
<ConfirmationModal
open={leaveWorkspaceModal}
alwaysPortal
title="Leave workspace"
confirmationText="Leave workspace"
on:canceled={() => {
frontend/src/routes/(root)/(logged)/+layout.svelte
+5 -1
View File
@@ -1515,8 +1515,12 @@
}
}
/* No forwards fill: a filled animation keeps `transform` animated after it ends, which makes
the rail the containing block for every `position: fixed` descendant — the confirmation
dialogs opened from the settings menu would be confined to the rail's column. The `to`
keyframe equals the rail's resting style, so nothing changes visually when the fill drops. */
:global(#sidebar.wm-sidebar-in) {
animation: wm-sidebar-in 500ms ease-out both;
animation: wm-sidebar-in 500ms ease-out;
}
@media (prefers-reduced-motion: reduce) {