mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-05 16:03:47 +00:00
fix(datatables): only the app that would name the data table is refused
A caller who may run as none of a permissioned data table's roles could not start anything: the refusal ignored whether the app was going to name it at all. With table creation off nothing saves the data table, and an app that never touches it is not theirs to be stopped over — so the buttons look at that, and the hint says what the way out is. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01S5arH3G2Sa1Qqm32veJQ1n
This commit is contained in:
co-authored by
Claude Opus 5
parent
4638f35951
commit
bdcd42ac0a
@@ -144,6 +144,10 @@
|
||||
roles.current.permissioned &&
|
||||
loadedRoles.length === 0
|
||||
)
|
||||
// Only the app that will name the data table is refused: with table creation
|
||||
// off nothing saves it, and an app that does not touch it is not this caller's
|
||||
// problem to be stopped over.
|
||||
const blockedByRole = $derived(noUsableRole && tableCreationEnabled)
|
||||
const accessSettled = $derived(
|
||||
hasNoDatatables ||
|
||||
(rolesSettled &&
|
||||
@@ -362,7 +366,9 @@
|
||||
/>
|
||||
{#if noUsableRole}
|
||||
<span class="text-xs text-red-600 dark:text-red-400">
|
||||
no role you can use
|
||||
{tableCreationEnabled
|
||||
? 'no role you can use — pick another data table, or turn off table creation'
|
||||
: 'no role you can use'}
|
||||
</span>
|
||||
{/if}
|
||||
{#if showRolePicker}
|
||||
@@ -545,7 +551,7 @@
|
||||
newSchemaAlreadyExists ||
|
||||
!rolesSettled ||
|
||||
!accessSettled ||
|
||||
noUsableRole}
|
||||
blockedByRole}
|
||||
>
|
||||
{$copilotInfo.workspaceDisabled ? 'Start' : 'Start without AI'}
|
||||
</Button>
|
||||
@@ -555,7 +561,7 @@
|
||||
on:click={() => start(true)}
|
||||
disabled={!rolesSettled ||
|
||||
!accessSettled ||
|
||||
noUsableRole ||
|
||||
blockedByRole ||
|
||||
!templates[selectedTemplateIndex] ||
|
||||
!initialPrompt.trim() ||
|
||||
newSchemaAlreadyExists}
|
||||
|
||||
Reference in New Issue
Block a user