mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-28 08:02:43 +00:00
fix(deploy-to-hub): keep item summary on rehydrated draft, drop placeholder diff button
Rehydrated draft items now carry their summary (from the Hub) so step 2 shows the summary like step 1 instead of falling back to the path. Remove the "Diff vs submitted" button: it only toasted add/remove counts with no view, which read as broken. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 4.8
parent
1a32b6e5ad
commit
c031f2ff53
@@ -49,7 +49,6 @@
|
||||
Code2,
|
||||
Copy,
|
||||
ExternalLink,
|
||||
GitCompare,
|
||||
Globe,
|
||||
Info,
|
||||
LayoutDashboard,
|
||||
@@ -424,6 +423,7 @@
|
||||
key,
|
||||
path: wpath,
|
||||
kind: it.kind as Kind,
|
||||
summary: it.summary ?? undefined,
|
||||
rec: it.has_recording ? 'recorded' : 'none'
|
||||
} satisfies DeployItem
|
||||
})
|
||||
@@ -1202,16 +1202,6 @@
|
||||
}
|
||||
}
|
||||
let syncing = $state(false)
|
||||
async function showDiff() {
|
||||
const workspace = $workspaceStore
|
||||
if (!workspace) return
|
||||
await loadWorkspace(workspace, workspaceLoadSeq)
|
||||
const draftKeys = new Set(draftItems.map((i) => i.key))
|
||||
const workspaceKeys = new Set(workspaceItems.map((i) => i.key))
|
||||
const added = workspaceItems.filter((i) => !draftKeys.has(i.key)).length
|
||||
const removed = draftItems.filter((i) => !workspaceKeys.has(i.key)).length
|
||||
sendUserToast(`Diff: +${added} added, -${removed} removed (vs submitted bundle).`)
|
||||
}
|
||||
async function syncWithHub() {
|
||||
const workspace = $workspaceStore
|
||||
if (!workspace) return
|
||||
@@ -1579,18 +1569,6 @@
|
||||
<ExternalLink size={12} /> Open in Hub
|
||||
</a>
|
||||
{/if}
|
||||
{#if phase === 'live'}
|
||||
<div class="ml-auto">
|
||||
<Button
|
||||
size="xs"
|
||||
variant="subtle"
|
||||
startIcon={{ icon: GitCompare }}
|
||||
onclick={showDiff}
|
||||
>
|
||||
Diff vs submitted
|
||||
</Button>
|
||||
</div>
|
||||
{/if}
|
||||
</div>
|
||||
{#if phase === 'predeploy'}
|
||||
<div class="flex flex-col gap-1 text-xs">
|
||||
|
||||
Reference in New Issue
Block a user