starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-21 00:02:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: drop a stale acting-user refusal on arrival rather than on departure

Browse Source 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01YLxwAsiXJ1Au8CBDBmH7iY
This commit is contained in:
Diego Imbert
2026-09-09 10:14:12 +02:00
co-authored by Claude Opus 5
parent af16c97127
commit c629914cfd
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/actingUser.svelte.ts
+13 -12
View File
@@ -25,17 +25,18 @@ export function useActingUser(workspace: () => string | undefined) {
// A Map, not an object: a workspace may legitimately be named `constructor`, which a plain
// object would answer for out of its prototype.
const looked = new SvelteMap<string, RoleLookup>()
// A lookup that came back empty is remembered only for as long as its workspace is the one
// being acted on, so the caller has a settled answer to show without the refusal outliving
// the attempt. Leaving that workspace ends the attempt; so does `forgetFailures`.
let shown: string | undefined
// The workspace this effect last acted on, so arriving at one is distinguishable from the
// effect re-running while already there.
let asking: string | undefined
$effect(() => {
const ws = workspace()
if (shown !== ws) {
const left = shown
shown = ws
if (left && untrack(() => looked.get(left)?.kind) === 'lookup_failed') looked.delete(left)
if (asking !== ws) {
asking = ws
// Dropped on the way *in*, not on the way out: a lookup that fails after the acting
// workspace has already moved on has no entry to clear at the moment it is left, so
// clearing it there would keep a refusal that no attempt is behind any more.
if (ws && untrack(() => looked.get(ws)?.kind) === 'lookup_failed') looked.delete(ws)
}
if (!ws || ws === navWorkspace.current) return
// Any settled answer stops the asking, a failure included — otherwise recording one
@@ -65,10 +66,10 @@ export function useActingUser(workspace: () => string | undefined) {
get current(): UserExt | undefined {
return userIn(workspace())
},
/** Drop the lookups that came back empty so they are asked again — the other way an
* attempt ends. A long-lived editor must call this when it starts a fresh session, or
* a `whoami` that happened to fail pins its workspace to "unknown user" until the
* acting workspace changes. */
/** Drop the lookups that came back empty so they are asked again. Arriving at a
* workspace already does this; a long-lived editor must call this too when it starts a
* fresh session on the workspace it is already on, or a `whoami` that happened to fail
* pins it to "unknown user" for as long as it stays there. */
forgetFailures(): void {
for (const [ws, lookup] of looked) {
if (lookup.kind === 'lookup_failed') looked.delete(ws)