starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-22 08:02:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(apps): allow setting sandbox isolation and public access before first deploy (#10085)

Browse Source 
* fix(apps): allow enabling sandbox isolation before first deploy

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix(apps): allow setting public access mode before first deploy

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
hugocasa
2026-07-14 17:19:42 +02:00
committed by GitHub
parent 98e6cca75d
commit cfc3f292ad
1 changed files with 16 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/apps/editor/AppEditorHeaderDeploy.svelte
+16 -5
View File
@@ -299,7 +299,13 @@
checked={policy.sandbox == true}
on:change={(e) => {
policy.sandbox = e.detail || undefined
setPublishState(e.detail ? 'Sandbox isolation enabled' : 'Sandbox isolation disabled')
// A not-yet-deployed app has no row to PATCH — `setPublishState` (POST
// /apps/update) would 404. The flag rides along in the `policy` the first
// deploy sends (createApp), so here we only mutate it locally. Persist
// incrementally once the app exists.
if (savedApp && !newApp) {
setPublishState(e.detail ? 'Sandbox isolation enabled' : 'Sandbox isolation disabled')
}
}}
disabled={!savedApp}
/>
@@ -310,8 +316,8 @@
on every surface (public URL and in-workspace). Leave it off if the app needs full browser
features (IndexedDB, third-party auth/SDKs, OAuth redirects).
</div>
{#if !savedApp}
<div class="text-xs text-tertiary mt-1">Save the app once to change this setting.</div>
{#if newApp}
<div class="text-xs text-tertiary mt-1">Takes effect when you first deploy this app.</div>
{/if}
{#if policy.sandbox == true}
<div class="mt-2">
@@ -343,9 +349,14 @@
checked={policy.execution_mode == 'anonymous'}
on:change={(e) => {
policy.execution_mode = e.detail ? 'anonymous' : 'publisher'
setPublishState()
// Same as sandbox: a not-yet-deployed app has no row to PATCH, so
// `setPublishState` would 404. The mode is carried by the first
// deploy's policy; persist incrementally only once the app exists.
if (savedApp && !newApp) {
setPublishState()
}
}}
disabled={!savedApp || newApp || (!canSetAnonymous && policy.execution_mode != 'anonymous')}
disabled={!savedApp || (!canSetAnonymous && policy.execution_mode != 'anonymous')}
/>
</div>
{#if !savedApp || newApp}