mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-06 08:01:35 +00:00
refactor(frontend): drop the InfiniteList containerClass prop
Added for the template picker, which turns out not to need it: DataTable's own container is already `h-full`, so `containerClass="h-full"` merged to nothing and the height the list pages against comes from the flex chain above it. A prop with no effect at its only call site is public surface for free. InfiniteList is back to what it was. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012fRjnaHLwjpHN84gNNxah9
This commit is contained in:
co-authored by
Claude Opus 5
parent
b3aa4a4cd3
commit
dc3689eb40
@@ -17,10 +17,6 @@
|
||||
extraRowClasses?: { bgSelected: string; bgHover: string; class: string }
|
||||
neverShowLoader?: boolean
|
||||
preventXOverflow?: boolean
|
||||
/** Applied to the table's outer box. A definite height here (rather than a max) is what
|
||||
* makes the inner scroll container page: it only scrolls, and so only asks for more,
|
||||
* when its own height is bounded. */
|
||||
containerClass?: string
|
||||
customRow?: import('svelte').Snippet<[any]>
|
||||
columns?: import('svelte').Snippet
|
||||
extra_row?: import('svelte').Snippet<[any]>
|
||||
@@ -43,7 +39,6 @@
|
||||
},
|
||||
neverShowLoader = false,
|
||||
preventXOverflow = false,
|
||||
containerClass = '',
|
||||
customRow,
|
||||
columns,
|
||||
extra_row,
|
||||
@@ -177,7 +172,6 @@
|
||||
{noBorder}
|
||||
{neverShowLoader}
|
||||
{preventXOverflow}
|
||||
{containerClass}
|
||||
>
|
||||
{@render columns?.()}
|
||||
|
||||
|
||||
@@ -64,7 +64,9 @@
|
||||
</p>
|
||||
|
||||
<div class="min-h-0 flex-1 border-t border-border-light">
|
||||
<InfiniteList bind:this={list} noBorder rounded={false} containerClass="h-full">
|
||||
<!-- The height comes from the flex chain above: DataTable's own container is `h-full`, so
|
||||
the scroll box inside it is bounded, which is what lets the list page. -->
|
||||
<InfiniteList bind:this={list} noBorder rounded={false}>
|
||||
{#snippet customRow({ item }: { item: HubProjectPick })}
|
||||
{@const Icon = hubAppIcon(item.iconApps[0] ?? '')}
|
||||
<tr>
|
||||
|
||||
Reference in New Issue
Block a user