starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-09-21 00:02:30 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: an unread head confirms with the copy for caution, not for an observed deploy

Browse Source 
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This commit is contained in:
Ruben Fiszel
2026-09-15 22:55:35 +02:00
co-authored by Claude Opus 5
parent 4b348bb0bf
commit df2973ffff
2 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/apps/editor/AppEditorHeader.svelte
+8 -2
View File
@@ -474,6 +474,9 @@
* beside it or the anchor read failed. Either way this editor has no base to compare,
* so the guard confirms. Set by `updateApp`. */
let baseUnknown = $state(false)
/** The last comparison could not read the head, so the confirmation it raises is
* caution and not an observed deploy. Cleared by the next reading comparison. */
let headUnknown = $state(false)
async function compareVersions() {
if (baseUnknown) {
// Nothing to compare against, so confirm rather than let the next deploy
@@ -495,11 +498,14 @@
path: $appPath
})
onLatest = appVersion?.version === undefined || base === appVersion?.version
headUnknown = false
} catch (e) {
console.error('Error comparing versions', e)
// The head is what this compares against, so an unanswered read is not
// evidence of being current: confirm, as an unclaimable deploy does.
// evidence of being current: confirm, as an unclaimable deploy does, and say
// that is why rather than claiming a version that was never seen.
onLatest = false
headUnknown = true
}
}
@@ -784,7 +790,7 @@
bind:open
{diffDrawer}
claimOpening={() => (lastOpening = diffDrawer?.beginOpening())}
{baseUnknown}
baseUnknown={baseUnknown || headUnknown}
bind:deployedValue
currentValue={{
summary: $summary,
frontend/src/lib/components/raw_apps/RawAppEditorHeader.svelte
+8 -2
View File
@@ -620,6 +620,9 @@
* beside it or the anchor read failed. Either way this editor has no base to compare,
* so the guard confirms. Set by `updateApp`. */
let baseUnknown = $state(false)
/** The last comparison could not read the head, so the confirmation it raises is
* caution and not an observed deploy. Cleared by the next reading comparison. */
let headUnknown = $state(false)
async function compareVersions() {
if (baseUnknown) {
// Nothing to compare against, so confirm rather than let the next deploy
@@ -636,11 +639,14 @@
path: appPath
})
onLatest = appVersion?.version === undefined || version === appVersion?.version
headUnknown = false
} catch (e) {
console.error('Error comparing versions', e)
// The head is what this compares against, so an unanswered read is not
// evidence of being current: confirm, as an unclaimable deploy does.
// evidence of being current: confirm, as an unclaimable deploy does, and say
// that is why rather than claiming a version that was never seen.
onLatest = false
headUnknown = true
}
}
@@ -734,7 +740,7 @@
bind:open
{diffDrawer}
claimOpening={() => (lastOpening = diffDrawer?.beginOpening())}
{baseUnknown}
baseUnknown={baseUnknown || headUnknown}
bind:deployedValue
currentValue={currentDiffValue}
/>