starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-10-21 08:03:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: say members can browse what a shared native trigger account can access

Browse Source 
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
hugocasa
2026-10-20 10:17:48 +02:00
co-authored by Claude Opus 5.5
parent 313ade29f8
commit df7cb315ca
2 changed files with 19 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
backend/windmill-api/openapi.yaml
+1 -1
View File
@@ -21118,7 +21118,7 @@ paths:
/w/{workspace}/native_triggers/integrations/{service_name}/workspace_connection:
post:
summary: share one of your connections with every member of the workspace, or stop sharing
summary: share a connection of this service with every member of the workspace (admin only), or stop sharing
operationId: setNativeTriggerWorkspaceConnection
tags:
- workspace_integration
frontend/src/lib/components/workspaceSettings/WorkspaceIntegrations.svelte
+18 -5
View File
@@ -157,17 +157,27 @@
}
}
async function setWorkspaceConnection(serviceName: string, path: string | undefined): Promise<boolean> {
async function setWorkspaceConnection(
serviceName: string,
path: string | undefined
): Promise<boolean> {
if (!$workspaceStore) return false
const displayName = supportedServices[serviceName]?.displayName ?? serviceName
if (path) {
const owner = connections[serviceName]?.find((c) => c.path === path)?.owner
const account = owner ? `this account, connected by ${owner}` : 'this account'
const browsable: string | undefined = (
{ google: 'its Drive files and calendars', github: 'its repositories' } as Record<
string,
string
>
)[serviceName]
const browse = browsable ? `, and browse ${browsable} in the trigger editor` : ''
const confirmed = await confirmationModal.ask({
title: `Share ${path} with the workspace?`,
confirmationText: 'Share',
children: `Every member will be able to create and edit ${displayName} triggers that act as ${account}. They will not see its token. It replaces any connection shared before.`
children: `Every member will be able to create and edit ${displayName} triggers that act as ${account}${browse}. They will not see its token. It replaces any connection shared before.`
})
if (!confirmed) return false
} else {
@@ -194,7 +204,6 @@
}
}
function docsItem(config: ServiceConfig): Item[] {
return config.docsUrl
? [{ displayName: 'Docs', icon: ExternalLink, href: config.docsUrl, hrefTarget: '_blank' }]
@@ -372,7 +381,10 @@
</div>
{#if serviceName === 'nextcloud' && !workspaceConnection}
<Alert type="info" title="Creating Nextcloud triggers requires a Nextcloud admin account">
<Alert
type="info"
title="Creating Nextcloud triggers requires a Nextcloud admin account"
>
We recommend connecting one below and sharing it with the workspace.
</Alert>
{/if}
@@ -380,7 +392,8 @@
<div class="flex flex-col gap-1">
<div class="text-xs font-semibold text-emphasis">Shared account</div>
<div class="text-xs text-secondary">
Members can create triggers as this account without seeing its token.
Members can create triggers as this account and pick from what it can access,
without seeing its token.
</div>
<div class="max-w-md">
<!-- Remounted so its list includes an account connected from elsewhere on the page. -->