refactor: remove expand button from GroupActionBar (handled by StepCountTab)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
Guilhem
2026-03-04 15:12:51 +00:00
co-authored by Claude Opus 4.6
parent 110e4c6789
commit dfaa5a4ac0
3 changed files with 5 additions and 32 deletions
@@ -1,6 +1,6 @@
<script lang="ts">
import { preventDefault, stopPropagation } from 'svelte/legacy'
import { Maximize2, Minimize2, Settings, StickyNote, Ungroup } from 'lucide-svelte'
import { Settings, StickyNote, Ungroup } from 'lucide-svelte'
import { NoteColor, NOTE_COLOR_SWATCHES } from './noteColors'
import Popover from '../meltComponents/Popover.svelte'
import { Tooltip } from '../meltComponents'
@@ -10,13 +10,9 @@
note: string | undefined | null
color: string | undefined
collapsedByDefault: boolean
collapsed: boolean
settingsOpen?: boolean
/** When false, non-collapse buttons are invisible (preserving layout) and the collapse button is dimmed */
showAll?: boolean
onAddNote: () => void
onRemoveNote: () => void
onToggleCollapse: () => void
onUpdateColor: (color: NoteColor) => void
onUpdateCollapsedDefault: (value: boolean) => void
onDeleteGroup?: () => void
@@ -26,12 +22,9 @@
note,
color,
collapsedByDefault,
collapsed,
settingsOpen = $bindable(false),
showAll = true,
onAddNote,
onRemoveNote,
onToggleCollapse,
onUpdateColor,
onUpdateCollapsedDefault,
onDeleteGroup = undefined
@@ -39,7 +32,7 @@
</script>
<div class="absolute -translate-y-[100%] top-2 right-0 h-7 p-1 flex flex-row gap-1">
<div class={showAll ? '' : 'invisible pointer-events-none'}>
<div>
{#if note == null}
<Tooltip>
<button
@@ -64,21 +57,7 @@
</Tooltip>
{/if}
</div>
<Tooltip>
<button
class="center-center text-secondary shadow-sm bg-surface duration-0 hover:bg-surface-tertiary p-1 rounded-md {showAll ? '' : 'opacity-50'}"
onclick={stopPropagation(preventDefault(onToggleCollapse))}
onpointerdown={stopPropagation(preventDefault(() => {}))}
>
{#if collapsed}
<Maximize2 size={12} />
{:else}
<Minimize2 size={12} />
{/if}
</button>
<svelte:fragment slot="text">{collapsed ? 'Expand' : 'Collapse'} group</svelte:fragment>
</Tooltip>
<div class={showAll ? '' : 'invisible pointer-events-none'}>
<div>
<Popover
placement="bottom"
contentClasses="p-4"
@@ -119,7 +98,7 @@
{/snippet}
</Popover>
</div>
<div class={showAll ? '' : 'invisible pointer-events-none'}>
<div>
{#if onDeleteGroup}
<Tooltip>
<button
@@ -199,11 +199,9 @@
note={group.note}
color={group.color}
collapsedByDefault={group.collapsed_by_default ?? false}
collapsed={false}
bind:settingsOpen
onAddNote={() => groupEditorContext?.groupEditor.addNote(group.id)}
onRemoveNote={() => groupEditorContext?.groupEditor.removeNote(group.id)}
onToggleCollapse={() => toggleCollapse(group.id)}
onUpdateColor={(c) => groupEditorContext?.groupEditor.updateColor(group.id, c)}
onUpdateCollapsedDefault={(v) => groupEditorContext?.groupEditor.updateCollapsedDefault(group.id, v)}
onDeleteGroup={() => {
@@ -18,7 +18,6 @@
const groupEditorContext = getGroupEditorContext()
let selected = $derived(!!(selectionManager && selectionManager.isNodeSelected(id)))
let hover = $state(false)
let group = $derived(
groupEditorContext?.groupEditor.getGroups().find((g) => g.id === data.groupId)
@@ -29,7 +28,7 @@
<NodeWrapper offset={data.offset}>
{#snippet children({ darkMode })}
<!-- svelte-ignore a11y_no_static_element_interactions -->
<div class="relative" onmouseenter={() => (hover = true)} onmouseleave={() => (hover = false)}>
<div class="relative">
<StepCountTab stepCount={data.stepCount} color={data.color} onExpand={() => data.eventHandlers.expandGroup(data.groupId)} />
@@ -54,11 +53,8 @@
note={data.note}
color={data.color}
collapsedByDefault={group?.collapsed_by_default ?? false}
collapsed={true}
showAll={hover || selected}
onAddNote={() => groupEditorContext?.groupEditor.addNote(data.groupId)}
onRemoveNote={() => groupEditorContext?.groupEditor.removeNote(data.groupId)}
onToggleCollapse={() => data.eventHandlers.expandGroup(data.groupId)}
onUpdateColor={(c) => groupEditorContext?.groupEditor.updateColor(data.groupId, c)}
onUpdateCollapsedDefault={(v) =>
groupEditorContext?.groupEditor.updateCollapsedDefault(data.groupId, v)}