mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-30 08:16:49 +00:00
feat: accept the google_service_account resource type alongside gcp_service_account (#12070)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
80a49f9bd3
commit
e480501af9
@@ -122,7 +122,7 @@ impl KnownAdapter {
|
||||
"duckdb" => Some(KnownAdapter::Duckdb),
|
||||
"clickhouse" => Some(KnownAdapter::Clickhouse),
|
||||
"snowflake" | "snowflake_oauth" => Some(KnownAdapter::Snowflake),
|
||||
"bigquery" | "gcp_service_account" => Some(KnownAdapter::Bigquery),
|
||||
"bigquery" | "google_service_account" | "gcp_service_account" => Some(KnownAdapter::Bigquery),
|
||||
"databricks" => Some(KnownAdapter::Databricks),
|
||||
"salesforce" => Some(KnownAdapter::Salesforce),
|
||||
"ms_sql_server" | "mssql" | "sqlserver" | "fabric" => Some(KnownAdapter::Mssql),
|
||||
@@ -1098,6 +1098,10 @@ mod tests {
|
||||
KnownAdapter::from_resource_type("fabric"),
|
||||
Some(KnownAdapter::Mssql)
|
||||
);
|
||||
assert_eq!(
|
||||
KnownAdapter::from_resource_type("google_service_account"),
|
||||
Some(KnownAdapter::Bigquery)
|
||||
);
|
||||
}
|
||||
|
||||
// `PartialEq` covers the carried name, so two spellings of one adapter must
|
||||
|
||||
+1
-1
@@ -236,7 +236,7 @@ points at the object-storage resource and a DuckLake names its catalog.
|
||||
|
||||
**What a warehouse may point at.** Either a Windmill connection resource whose
|
||||
type `render_profile` translates (`postgresql`, `redshift`, `mysql`, `snowflake`,
|
||||
`snowflake_oauth`, `bigquery`, `gcp_service_account`, `databricks`), or a
|
||||
`snowflake_oauth`, `bigquery`, `google_service_account`, `gcp_service_account`, `databricks`), or a
|
||||
**`dbt_profile`** resource, whose VALUE IS one entry of that file's `outputs`
|
||||
map — `type` included, nothing lifted out or renamed. A block is copied from a
|
||||
working `profiles.yml` and pasted in, which is the whole point: a type that asked
|
||||
|
||||
@@ -152,7 +152,7 @@ repeatedly — check the brand's own page.
|
||||
| `GoogleCloudIcon` | `gcloud`, `gcp_service_account` | fixed | #EA4335 | #EA4335 | 3.80 | 7.30 | Google's own product logo asset https://www.gstatic.com/images/branding/product/2x/google_cloud_64dp.png |
|
||||
| `GoogleDriveIcon` | — | fixed | #B43333 | #B43333 | 5.87 | 10.05 | https://www.gstatic.com/images/branding/productlogos/drive_2026/v2/web/192px.svg (Drive 2026 mark, copied verbatim) |
|
||||
| `GoogleFormsIcon` | `gforms` | fixed | #969DFF | #969DFF | 5.99 | 12.47 | Google's own Forms product icon at www.gstatic.com/images/branding/productlogos/forms_2026/v2/web/192px.svg |
|
||||
| `GoogleIcon` | `google`, `gworkspace` | mixed | #4285F4 | #4285F4 | 3.88 | 7.30 | the G mark Google serves in accounts.google.com/gsi/client |
|
||||
| `GoogleIcon` | `google`, `gworkspace`, `google_service_account` | mixed | #4285F4 | #4285F4 | 3.88 | 7.30 | the G mark Google serves in accounts.google.com/gsi/client |
|
||||
| `GorgiasIcon` | `gorgias` | pair | #000000 | #FFF9F4 | 20.32 | 11.94 | gorgias.com/about-us/style, which ships the symbol as a "Dark"/"Light" pair |
|
||||
| `GraphqlIcon` | `graphql` | pair | #E10098 | #FFFFFF | 4.37 | 12.47 | graphql.org |
|
||||
| `GreipIcon` | `greip` | pair | #141C27 | #FFFFFF | 16.59 | 12.47 | docs.greip.io |
|
||||
|
||||
@@ -361,7 +361,8 @@ export const APP_TO_ICON_COMPONENT = {
|
||||
gsheets: GSheetsIcon,
|
||||
gitlab: GitlabIcon,
|
||||
// `gcloud` and `gcp_service_account` are both Google Cloud, so both resolve to the
|
||||
// official four-colour mark.
|
||||
// official four-colour mark. `google_service_account` also serves Workspace APIs,
|
||||
// so it takes the G mark like `gworkspace`.
|
||||
gcloud: GoogleCloudIcon,
|
||||
gcal: GcalIcon,
|
||||
gdrive: GdriveIcon,
|
||||
@@ -460,6 +461,7 @@ export const APP_TO_ICON_COMPONENT = {
|
||||
ipinfo: IpinfoIcon,
|
||||
gworkspace: GoogleIcon,
|
||||
gcp_service_account: GoogleCloudIcon,
|
||||
google_service_account: GoogleIcon,
|
||||
cacertificate: CaCertificate,
|
||||
currencyapi: CurrencyApiIcon,
|
||||
visma: VismaIcon,
|
||||
|
||||
@@ -21,6 +21,7 @@
|
||||
'snowflake',
|
||||
'snowflake_oauth',
|
||||
'bigquery',
|
||||
'google_service_account',
|
||||
'gcp_service_account',
|
||||
'databricks'
|
||||
].join(',')
|
||||
|
||||
Reference in New Issue
Block a user