starred/windmill
1
0
Fork 0
mirror of https://github.com/windmill-labs/windmill.git synced 2026-08-25 08:00:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: session preview editors and picker dropdown overflow (#10010)

Browse Source 
* fix: constrain script/flow/raw-app editors to container height in session preview

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* fix: clip session preview picker dropdown to popover so it stops overflowing the page

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
Guilhem
2026-07-08 15:56:31 +02:00
committed by GitHub
parent a00ee5196b
commit fb12b23e01
5 changed files with 7 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/src/lib/components/DrillPicker.svelte
+1 -1
View File
@@ -412,7 +412,7 @@ leaves and ignores the current scope.
bind:this={pickerRoot}
class={flush
? 'flex flex-col w-full h-full'
: 'flex flex-col w-[min(420px,calc(100vw-20px))] max-h-[60vh]'}
: 'flex flex-col w-[min(420px,calc(100vw-20px))] max-h-[60vh] min-h-0'}
onkeydown={handleSearchKeydown}
onmousemove={() => (mouseActive = true)}
>
frontend/src/lib/components/FlowBuilder.svelte
+1 -1
View File
@@ -1097,7 +1097,7 @@
<ScriptEditorDrawer bind:this={$scriptEditorDrawer} />
<FlowEditorDrawer bind:this={$flowEditorDrawer} />
<div bind:this={flowBuilderRoot} class="flex flex-col h-screen">
<div bind:this={flowBuilderRoot} class="flex flex-col h-full">
<!-- Nav between steps-->
<div
bind:clientWidth={topbarWidth}
frontend/src/lib/components/ScriptBuilder.svelte
+1 -1
View File
@@ -1897,7 +1897,7 @@
</DrawerContent>
</Drawer>
<div class="flex flex-col h-screen">
<div class="flex flex-col h-full">
<div bind:clientWidth={topbarWidth} class="flex h-12 items-center px-4">
<div class="flex gap-2 lg:gap-2 w-full items-center">
<div class="flex flex-row items-center gap-2 min-w-0 shrink">
frontend/src/lib/components/raw_apps/RawAppEditor.svelte
+1 -4
View File
@@ -1643,10 +1643,7 @@
gateJobIds={false}
extraSourceWindow={() => externalPreviewWindow}
/>
<div
bind:clientWidth={rootWidth}
class="max-h-screen overflow-hidden h-screen min-h-0 flex flex-col"
>
<div bind:clientWidth={rootWidth} class="max-h-full overflow-hidden h-full min-h-0 flex flex-col">
<RawAppEditorHeader
bind:jobs
bind:jobsById
frontend/src/routes/(root)/(logged)/sessions/+page.svelte
+3
View File
@@ -655,6 +655,7 @@
enableFlyTransition
bind:isOpen={activeTabPickerOpen}
openFocus="[data-workspace-picker-search]"
contentClasses="flex flex-col overflow-hidden"
class="flex items-center shrink-0 cursor-pointer text-tertiary hover:text-primary"
>
{#snippet trigger()}
@@ -685,6 +686,7 @@
bind:isOpen={newTabOpen}
enableFlyTransition
openFocus="[data-workspace-picker-search]"
contentClasses="flex flex-col overflow-hidden"
class="shrink-0 inline-flex items-center justify-center w-6 h-6 rounded text-tertiary hover:text-primary hover:bg-surface-hover cursor-pointer"
>
{#snippet trigger()}
@@ -753,6 +755,7 @@
bind:isOpen={emptyStateNewTabOpen}
enableFlyTransition
openFocus="[data-workspace-picker-search]"
contentClasses="flex flex-col overflow-hidden"
>
{#snippet trigger()}
<span