mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-09-06 00:02:13 +00:00
fix(frontend): let Skip wait for the workspace onboarding names
`loadWorkspaceStep()` was fired and dropped, while Skip and the use-case Continue branch on `ownWorkspace` in their `finally`. Skip awaits one POST that starts after those two GETs and can finish before them, so a first-frame Skip fell through to `leaveOnboarding()` and landed in the workspace with the backend's name — the step this flow exists for, silently gone. Both exits await the load; `isSubmitting` already covers the wait. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012fRjnaHLwjpHN84gNNxah9
This commit is contained in:
co-authored by
Claude Opus 5
parent
d197d68fc8
commit
ff3842aeb3
@@ -72,7 +72,10 @@
|
||||
console.error('Could not prepare the workspace step:', error)
|
||||
}
|
||||
}
|
||||
void loadWorkspaceStep()
|
||||
// Held, not dropped: Skip awaits one POST that can finish before these two GETs do, and
|
||||
// branching on `ownWorkspace` before they land would skip the naming step this flow exists
|
||||
// for. Both exits await it; `isSubmitting` already covers the wait.
|
||||
const workspaceStepReady = loadWorkspaceStep()
|
||||
|
||||
const sources = [
|
||||
{ id: 'ai_search', label: 'AI search', icon: Bot },
|
||||
@@ -202,6 +205,7 @@
|
||||
console.error('Error submitting onboarding data:', error)
|
||||
sendUserToast('Failed to save information: ' + (error?.body || error?.message || error), true)
|
||||
} finally {
|
||||
await workspaceStepReady
|
||||
isSubmitting = false
|
||||
// do not block users from accessing windmill even if there is an error
|
||||
if (ownWorkspace) {
|
||||
@@ -221,6 +225,7 @@
|
||||
} catch (error) {
|
||||
console.error('Error skipping onboarding:', error)
|
||||
} finally {
|
||||
await workspaceStepReady
|
||||
isSubmitting = false
|
||||
// Skipping the survey is not skipping naming the workspace: the questions are ours,
|
||||
// the workspace is theirs.
|
||||
|
||||
Reference in New Issue
Block a user