mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-08-21 00:02:23 +00:00
Ruben Fiszel
e86c41e038
- Remove the #!exec branch entirely (RCE backdoor — Claude/Codex/Pi all flagged shell injection via file contents) - Validate workspace and filename for empty / path-separator / .. before joining (path traversal — all three reviewers flagged) - Switch to tokio::fs and make the function async (Claude + Pi flagged blocking I/O in a likely async caller) - Canonicalize base and target as defense-in-depth and enforce target stays under the per-workspace configs directory - Tighten the doc comment: drop the #!exec wording and note the caller must verify admin access Leaving the dead_code/unwired pub fn as-is for now — the helper will land together with the admin endpoint that consumes it in a follow-up, which keeps this PR's diff minimal. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Windmill Backend
This folder holds all backend components, the src/ folder only contains files used to build the "root" binary.
Components
| name | description |
|---|---|
| windmill-api | The API server, exposing functionality to other components and the frontend |
| windmill-audit | Contains audit functionality, allowing different components to record important actions |
| windmill-common | Common code shared by all crates |
| windmill-queue | Contains job & flow queuing functionality, commonly written to by the API server and read from by workers |
| windmill-worker | The worker. Used to process and execute flows & jobs. |
| parsers | Contains code to parse signatures in different langauges. |
Compile sqlx for offline ci
cargo sqlx prepare --workspace -- --bin windmill --features enterprise