Ruben FiszelandClaude Opus 4.7 e86c41e038 test: address review feedback on read_admin_config_file ...

- Remove the #!exec branch entirely (RCE backdoor — Claude/Codex/Pi all
  flagged shell injection via file contents)
- Validate workspace and filename for empty / path-separator / .. before
  joining (path traversal — all three reviewers flagged)
- Switch to tokio::fs and make the function async (Claude + Pi flagged
  blocking I/O in a likely async caller)
- Canonicalize base and target as defense-in-depth and enforce target
  stays under the per-workspace configs directory
- Tighten the doc comment: drop the #!exec wording and note the caller
  must verify admin access

Leaving the dead_code/unwired pub fn as-is for now — the helper will
land together with the admin endpoint that consumes it in a follow-up,
which keeps this PR's diff minimal.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

2026-05-04 17:01:45 +00:00

..

examples

fix: enrich OTEL log records with per-request LogContext (#8812)

2026-04-13 21:50:50 +00:00

src

test: address review feedback on read_admin_config_file

2026-05-04 17:01:45 +00:00

tests

refactor: convert read-hot globals to AtomicBool/I64 and ArcSwap (#8815)

2026-04-14 00:04:10 +00:00

Cargo.toml

fix: add aws-config to private feature to restore ce build

2026-04-22 19:31:34 +00:00