mirror of
https://github.com/windmill-labs/windmill.git
synced 2026-10-21 16:03:26 +00:00
hugocasaandClaude Opus 4.6
1503bf948e
* fix: stop_after_if with empty error_message no longer prevents flow from stopping When skip_if_stopped=true and error_message="" were both set, the flow would continue executing instead of stopping because the empty string was converted to a default error message, which triggered the error handler path. Now skip_if_stopped takes precedence and the two options are treated as mutually exclusive in both backend and frontend. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> * chore: regenerate system prompts after openflow schema change Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
369 lines
12 KiB
Svelte
369 lines
12 KiB
Svelte
<script lang="ts">
|
|
import SimpleEditor from '$lib/components/SimpleEditor.svelte'
|
|
import Toggle from '$lib/components/Toggle.svelte'
|
|
import PropPickerWrapper from '$lib/components/flows/propPicker/PropPickerWrapper.svelte'
|
|
import type { Flow, FlowModule } from '$lib/gen'
|
|
import Tooltip from '$lib/components/Tooltip.svelte'
|
|
import type { ExtendedOpenFlow, FlowEditorContext } from '../types'
|
|
import { getContext } from 'svelte'
|
|
import { NEVER_TESTED_THIS_FAR } from '../models'
|
|
import Section from '$lib/components/Section.svelte'
|
|
import { getStepPropPicker } from '../previousResults'
|
|
import { dfs } from '../previousResults'
|
|
|
|
const { flowStateStore, flowStore, previewArgs } =
|
|
getContext<FlowEditorContext>('FlowEditorContext')
|
|
|
|
interface Props {
|
|
flowModule: FlowModule
|
|
}
|
|
|
|
let { flowModule = $bindable() }: Props = $props()
|
|
|
|
let editor: SimpleEditor | undefined = $state(undefined)
|
|
let stepPropPicker = $derived(
|
|
getStepPropPicker(
|
|
flowStateStore.val,
|
|
undefined,
|
|
undefined,
|
|
flowModule.id,
|
|
flowStore.val,
|
|
previewArgs.val,
|
|
false
|
|
)
|
|
)
|
|
|
|
function checkIfBreakableParent(
|
|
flowStoreValue: ExtendedOpenFlow
|
|
):
|
|
| { stepId: string; isParallel: boolean; type: 'loop' }
|
|
| { stepId: string; isParallel: true; type: 'branchall' }
|
|
| null {
|
|
const flow: Flow = JSON.parse(JSON.stringify(flowStoreValue))
|
|
const parents = dfs(flowModule.id, flow, true)
|
|
for (const parent of parents.slice(1)) {
|
|
if (parent.value.type === 'forloopflow' || parent.value.type === 'whileloopflow') {
|
|
return { stepId: parent.id, isParallel: parent.value.parallel ?? false, type: 'loop' }
|
|
} else if (parent.value.type === 'branchall' && parent.value.parallel) {
|
|
return { stepId: parent.id, isParallel: true, type: 'branchall' }
|
|
}
|
|
}
|
|
return null
|
|
}
|
|
let raise_error_message_stop_after_all_if = $state(
|
|
flowModule.stop_after_all_iters_if?.error_message != undefined
|
|
)
|
|
let raise_error_message_stop_after_if = $state(
|
|
flowModule.stop_after_if?.error_message != undefined
|
|
)
|
|
let { isLoop, isParallelLoop } = $derived(
|
|
flowModule.value.type === 'forloopflow' || flowModule.value.type === 'whileloopflow'
|
|
? { isLoop: true, isParallelLoop: flowModule.value.parallel ?? false }
|
|
: { isLoop: false, isParallelLoop: false }
|
|
)
|
|
let isBranchAll = $derived(flowModule.value.type === 'branchall')
|
|
let isStopAfterIfEnabled = $derived(Boolean(flowModule.stop_after_if))
|
|
let isStopAfterAllIterationsEnabled = $derived(Boolean(flowModule.stop_after_all_iters_if))
|
|
let result = $derived(flowStateStore.val[flowModule.id]?.previewResult ?? NEVER_TESTED_THIS_FAR)
|
|
let breakableParent = $derived(checkIfBreakableParent(flowStore.val))
|
|
</script>
|
|
|
|
<div class="flex flex-col items-start space-y-2">
|
|
{#if !isBranchAll && !isParallelLoop}
|
|
<Section
|
|
label={(isLoop
|
|
? 'Break loop'
|
|
: breakableParent
|
|
? breakableParent.isParallel
|
|
? breakableParent.type === 'loop'
|
|
? 'Skip rest of steps in iteration'
|
|
: 'Skip rest of steps in branch'
|
|
: 'Break parent loop module ' + breakableParent.stepId
|
|
: 'Stop flow early') + (isLoop ? ' (evaluated after each iteration)' : '')}
|
|
class="w-full"
|
|
>
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/flows/early_stop">
|
|
If defined, at the end of the step, the predicate expression will be evaluated to decide
|
|
if the flow should stop early, skip rest of steps in iteration/branch if inside a parallel
|
|
for loop or branch all, or break if inside a for/while loop or branch all.
|
|
</Tooltip>
|
|
{/snippet}
|
|
|
|
<Toggle
|
|
checked={isStopAfterIfEnabled}
|
|
on:change={() => {
|
|
if (isStopAfterIfEnabled && flowModule.stop_after_if) {
|
|
flowModule.stop_after_if = undefined
|
|
} else {
|
|
flowModule.stop_after_if = {
|
|
expr: 'result == undefined',
|
|
skip_if_stopped: false,
|
|
error_message: undefined
|
|
}
|
|
}
|
|
}}
|
|
options={{
|
|
right: isLoop
|
|
? 'Break loop'
|
|
: breakableParent
|
|
? breakableParent.isParallel
|
|
? breakableParent.type === 'loop'
|
|
? 'Skip rest of steps in iteration'
|
|
: 'Skip rest of steps in branch'
|
|
: 'Break parent loop module'
|
|
: 'Stop flow if condition met'
|
|
}}
|
|
/>
|
|
|
|
<div
|
|
class="w-full mt-2 border rounded-md p-2 flex flex-col gap-2 {flowModule.stop_after_if
|
|
? ''
|
|
: 'bg-surface-secondary'}"
|
|
>
|
|
{#if flowModule.stop_after_if}
|
|
{@const earlyStopResult = isLoop
|
|
? Array.isArray(result) && result.length > 0
|
|
? result[result.length - 1]
|
|
: result === NEVER_TESTED_THIS_FAR
|
|
? result
|
|
: undefined
|
|
: result}
|
|
{#if !breakableParent && !isLoop}
|
|
<div class="flex flex-col gap-2">
|
|
<Toggle
|
|
size="xs"
|
|
bind:checked={flowModule.stop_after_if.skip_if_stopped}
|
|
on:change={(event) => {
|
|
if (flowModule.stop_after_if && event.detail) {
|
|
flowModule.stop_after_if.error_message = undefined
|
|
raise_error_message_stop_after_if = false
|
|
}
|
|
}}
|
|
options={{
|
|
right: 'Label flow as "skipped" if stopped'
|
|
}}
|
|
/>
|
|
<Toggle
|
|
size="xs"
|
|
bind:checked={raise_error_message_stop_after_if}
|
|
on:change={(event) => {
|
|
if (flowModule.stop_after_if) {
|
|
if (event.detail) {
|
|
flowModule.stop_after_if.error_message = ''
|
|
flowModule.stop_after_if.skip_if_stopped = false
|
|
} else {
|
|
flowModule.stop_after_if.error_message = undefined
|
|
}
|
|
}
|
|
}}
|
|
options={{
|
|
right: 'Raise an error message if stopped',
|
|
rightTooltip:
|
|
'If enabled and the stop condition is met, an error message will be raised. A custom message can be provided; otherwise, a default message will be used. Mutually exclusive with "Label flow as skipped".'
|
|
}}
|
|
/>
|
|
</div>
|
|
{/if}
|
|
{#if raise_error_message_stop_after_if}
|
|
<input
|
|
type="text"
|
|
bind:value={flowModule.stop_after_if.error_message}
|
|
placeholder="Enter custom error message (optional)"
|
|
/>
|
|
{/if}
|
|
<span class="mt-2 text-xs font-bold">Stop condition expression</span>
|
|
<div class="border rounded-md w-full overflow-auto">
|
|
<PropPickerWrapper
|
|
noPadding
|
|
notSelectable
|
|
pickableProperties={stepPropPicker.pickableProperties}
|
|
result={earlyStopResult}
|
|
extraResults={isLoop ? { all_iters: result } : undefined}
|
|
on:select={({ detail }) => {
|
|
editor?.insertAtCursor(detail)
|
|
editor?.focus()
|
|
}}
|
|
>
|
|
<SimpleEditor
|
|
bind:this={editor}
|
|
lang="javascript"
|
|
bind:code={flowModule.stop_after_if.expr}
|
|
class="h-full"
|
|
extraLib={`declare const result = ${JSON.stringify(earlyStopResult)};\n` +
|
|
stepPropPicker.extraLib +
|
|
(isLoop ? `\ndeclare const all_iters = ${JSON.stringify(result)};` : '')}
|
|
/>
|
|
</PropPickerWrapper>
|
|
</div>
|
|
{:else}
|
|
{#if !breakableParent && !isLoop}
|
|
<div class="flex flex-col gap-2">
|
|
<Toggle
|
|
disabled
|
|
size="xs"
|
|
options={{
|
|
right: 'Label flow as "skipped" if stopped'
|
|
}}
|
|
/>
|
|
<Toggle
|
|
disabled
|
|
size="xs"
|
|
options={{
|
|
right: 'Raise an error message if stopped'
|
|
}}
|
|
/>
|
|
</div>
|
|
{/if}
|
|
<span class="mt-2 text-xs font-bold">Stop condition expression</span>
|
|
<textarea disabled rows="3" class="min-h-[80px]"></textarea>
|
|
{/if}
|
|
</div>
|
|
</Section>
|
|
{/if}
|
|
|
|
{#if isLoop || isBranchAll}
|
|
<Section
|
|
label={(breakableParent
|
|
? breakableParent.isParallel
|
|
? breakableParent.type === 'loop'
|
|
? 'Skip rest of steps in iteration'
|
|
: 'Skip rest of steps in branch'
|
|
: 'Break parent loop module ' + breakableParent.stepId
|
|
: 'Stop flow early') +
|
|
(isBranchAll
|
|
? ' (evaluated after all branches have been run)'
|
|
: ' (evaluated after all iterations)')}
|
|
class="w-full"
|
|
>
|
|
{#snippet header()}
|
|
<Tooltip documentationLink="https://www.windmill.dev/docs/flows/early_stop">
|
|
If defined, at the end of the step, the predicate expression will be evaluated to decide
|
|
if the flow should stop early, skip rest of steps in iteration/branch if inside a parallel
|
|
for loop or branch all, or break if inside a for/while loop or branch all.
|
|
</Tooltip>
|
|
{/snippet}
|
|
|
|
<Toggle
|
|
checked={isStopAfterAllIterationsEnabled}
|
|
on:change={() => {
|
|
if (isStopAfterAllIterationsEnabled && flowModule.stop_after_all_iters_if) {
|
|
flowModule.stop_after_all_iters_if = undefined
|
|
} else {
|
|
flowModule.stop_after_all_iters_if = {
|
|
expr: 'result == undefined',
|
|
skip_if_stopped: false,
|
|
error_message: undefined
|
|
}
|
|
}
|
|
}}
|
|
options={{
|
|
right:
|
|
(breakableParent
|
|
? breakableParent.isParallel
|
|
? breakableParent.type === 'loop'
|
|
? 'Skip rest of steps in iteration'
|
|
: 'Skip rest of steps in branch'
|
|
: 'Break parent loop module ' + breakableParent.stepId
|
|
: 'Stop flow') + ' if condition met'
|
|
}}
|
|
/>
|
|
|
|
<div
|
|
class="w-full border rounded-md mt-2 p-2 flex flex-col gap-2 {flowModule.stop_after_all_iters_if
|
|
? ''
|
|
: 'bg-surface-secondary'}"
|
|
>
|
|
{#if flowModule.stop_after_all_iters_if}
|
|
{#if !breakableParent}
|
|
<div class="flex flex-col gap-2">
|
|
<Toggle
|
|
size="xs"
|
|
bind:checked={flowModule.stop_after_all_iters_if.skip_if_stopped}
|
|
on:change={(event) => {
|
|
if (flowModule.stop_after_all_iters_if && event.detail) {
|
|
flowModule.stop_after_all_iters_if.error_message = undefined
|
|
raise_error_message_stop_after_all_if = false
|
|
}
|
|
}}
|
|
options={{
|
|
right: 'Label flow as "skipped" if stopped'
|
|
}}
|
|
/>
|
|
<Toggle
|
|
size="xs"
|
|
bind:checked={raise_error_message_stop_after_all_if}
|
|
on:change={(event) => {
|
|
if (flowModule.stop_after_all_iters_if) {
|
|
if (event.detail) {
|
|
flowModule.stop_after_all_iters_if.error_message = ''
|
|
flowModule.stop_after_all_iters_if.skip_if_stopped = false
|
|
} else {
|
|
flowModule.stop_after_all_iters_if.error_message = undefined
|
|
}
|
|
}
|
|
}}
|
|
options={{
|
|
right: 'Raise an error message if stopped',
|
|
rightTooltip:
|
|
'If enabled and the stop condition is met, an error message will be raised. A custom message can be provided; otherwise, a default message will be used. Mutually exclusive with "Label flow as skipped".'
|
|
}}
|
|
/>
|
|
</div>
|
|
{/if}
|
|
{#if raise_error_message_stop_after_all_if}
|
|
<input
|
|
type="text"
|
|
bind:value={flowModule.stop_after_all_iters_if.error_message}
|
|
placeholder="Enter custom error message (optional)"
|
|
/>
|
|
{/if}
|
|
<span class="mt-2 text-xs font-bold">Stop condition expression</span>
|
|
<div class="border rounded-md w-full overflow-auto">
|
|
<PropPickerWrapper
|
|
notSelectable
|
|
noPadding
|
|
pickableProperties={stepPropPicker.pickableProperties}
|
|
{result}
|
|
on:select={({ detail }) => {
|
|
editor?.insertAtCursor(detail)
|
|
editor?.focus()
|
|
}}
|
|
>
|
|
<SimpleEditor
|
|
bind:this={editor}
|
|
lang="javascript"
|
|
bind:code={flowModule.stop_after_all_iters_if.expr}
|
|
class="h-full"
|
|
extraLib={`declare const result = ${JSON.stringify(result)};\n` +
|
|
stepPropPicker.extraLib}
|
|
/>
|
|
</PropPickerWrapper>
|
|
</div>
|
|
{:else}
|
|
{#if !breakableParent}
|
|
<div class="flex flex-col gap-2">
|
|
<Toggle
|
|
disabled
|
|
size="xs"
|
|
options={{
|
|
right: 'Label flow as "skipped" if stopped'
|
|
}}
|
|
/>
|
|
<Toggle
|
|
disabled
|
|
size="xs"
|
|
options={{
|
|
right: 'Raise an error message if stopped'
|
|
}}
|
|
/>
|
|
</div>
|
|
{/if}
|
|
<span class="mt-2 text-xs font-bold">Stop condition expression</span>
|
|
<textarea disabled rows="3" class="min-h-[80px]"></textarea>
|
|
{/if}
|
|
</div>
|
|
</Section>
|
|
{/if}
|
|
</div>
|