resolve PR comments

Signed-off-by: luofucong <luofc@foxmail.com>
This commit is contained in:
luofucong
2026-05-13 09:51:37 +08:00
parent ea639584d9
commit f88e3ee45c
3 changed files with 5 additions and 9 deletions

View File

@@ -1094,6 +1094,7 @@ impl CompactionSstReaderBuilder<'_> {
let parquet_metadata = self
.sst_layer
.read_sst(file_handle.clone())
.cache(CacheStrategy::Compaction(self.cache))
.read_parquet_metadata(
&file_path,
file_size,
@@ -1108,9 +1109,7 @@ impl CompactionSstReaderBuilder<'_> {
file_metadata.schema_descr(),
file_metadata.key_value_metadata(),
)
.with_context(|_| ParquetToArrowSchemaSnafu {
parquet_metadata: format!("{:?}", parquet_metadata),
})?;
.context(ParquetToArrowSchemaSnafu { file: file_path })?;
schemas.push(schema);
}

View File

@@ -1249,12 +1249,9 @@ pub enum Error {
location: Location,
},
#[snafu(display(
"Failed generate Arrow schema from Parquet metadata: {}",
parquet_metadata
))]
#[snafu(display("Failed to generate Arrow schema from Parquet file: {}", file))]
ParquetToArrowSchema {
parquet_metadata: String,
file: String,
#[snafu(source)]
error: parquet::errors::ParquetError,
#[snafu(implicit)]

View File

@@ -753,7 +753,7 @@ pub(crate) fn concretize_json_types(
};
debug!(
"column {} set concretize JSON type {}",
"column {} concretized JSON type set to {}",
column_schema.name, json_type,
);
column_schema.data_type = ConcreteDataType::from(json_type);