rust/lancedb
1
0
Fork 0
mirror of https://github.com/lancedb/lancedb.git synced 2026-05-18 04:20:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix: pass storage_options in LanceNamespaceDatabase::create_table"

Browse Source 
This reverts commit 1078983993.
This commit is contained in:
Jack Ye
2026-01-30 17:28:15 -08:00
parent a11d28eb33
commit 381e7cb9a6
1 changed files with 1 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

19
rust/lancedb/src/database/namespace.rs
View File

@@ -7,8 +7,6 @@ use std::collections::HashMap;
use std::sync::Arc;
use async_trait::async_trait;
use lance::io::ObjectStoreParams;
use lance_io::object_store::StorageOptionsAccessor;
use lance_namespace::{
models::{
CreateEmptyTableRequest, CreateNamespaceRequest, CreateNamespaceResponse,
@@ -255,21 +253,6 @@ impl Database for LanceNamespaceDatabase {
}
};
// Inject storage_options into write params if we have them
let mut params = request.write_options.lance_write_params;
if !self.storage_options.is_empty() {
let params_ref = params.get_or_insert_with(Default::default);
let store_params = params_ref
.store_params
.get_or_insert_with(ObjectStoreParams::default);
// Only set if not already set by user
if store_params.storage_options_accessor.is_none() {
store_params.storage_options_accessor = Some(Arc::new(
StorageOptionsAccessor::with_static_options(self.storage_options.clone()),
));
}
}
let native_table = NativeTable::create_from_namespace(
self.namespace.clone(),
&location,
@@ -277,7 +260,7 @@ impl Database for LanceNamespaceDatabase {
request.namespace.clone(),
request.data,
None, // write_store_wrapper not used for namespace connections
params,
request.write_options.lance_write_params,
self.read_consistency_interval,
self.server_side_query_enabled,
self.session.clone(),