leptos-shadcn-ui/docs/remediation/signal-management-fix.md

🔧 Signal Management Package Fix

Critical Issues Identified

Compilation Errors (500+)

• Ownership Issues: cleanup moved due to method call in integration_tests.rs:258
• API Mismatches: Tests written against non-existent APIs
• Import Issues: Missing or incorrect imports across test modules

Root Cause Analysis

The recent file size optimization refactoring broke the signal management package by:

1. Splitting large test files without updating imports
2. Creating API mismatches between test expectations and actual implementation
3. Introducing ownership issues in cleanup operations

Fix Strategy

Phase 1: Fix Compilation Errors

1.1 Fix Ownership Issues

// BEFORE (BROKEN):
cleanup.cleanup(); // Takes ownership
assert_eq!(cleanup.signals_count(), 0); // ❌ Use after move

// AFTER (FIXED):
let signals_count = cleanup.signals_count();
cleanup.cleanup(); // Take ownership after use
assert_eq!(signals_count, 0);

1.2 Fix Import Issues

// Add missing imports to all test modules:
use leptos::prelude::*;
use crate::*;

1.3 Fix API Mismatches

• Remove tests for non-existent APIs
• Align tests with actual signal management implementation
• Update test expectations to match real behavior

Phase 2: Restructure Test Modules

2.1 Consolidate Related Tests

• Basic Types Tests: Theme, Variant, Size, ResponsiveConfig
• Signal Manager Tests: TailwindSignalManager functionality
• Cleanup Tests: SignalCleanup operations
• Memory Tests: SignalMemoryManager operations
• Performance Tests: BatchedSignalUpdater and performance characteristics

2.2 Fix Module Dependencies

// Fix module structure:
pub mod signal_management_tests {
    pub mod basic_types_tests;
    pub mod signal_manager_tests;
    pub mod cleanup_tests;
    pub mod memory_tests;
    pub mod performance_tests;
}

Phase 3: Implement Missing Functionality

3.1 Complete SignalCleanup Implementation

impl SignalCleanup {
    pub fn signals_count(&self) -> usize {
        self.signals.len()
    }
    
    pub fn memos_count(&self) -> usize {
        self.memos.len()
    }
    
    pub fn cleanup(mut self) -> Result<(), SignalManagementError> {
        // Implementation
        Ok(())
    }
}

3.2 Fix BatchedSignalUpdater

impl BatchedSignalUpdater {
    pub fn queue_update(&mut self, update: SignalUpdate) {
        self.pending_updates.push(update);
    }
    
    pub fn flush_updates(&mut self) -> Result<(), SignalManagementError> {
        // Implementation
        Ok(())
    }
}

Implementation Plan

Week 1: Critical Fixes

• Fix all compilation errors
• Resolve ownership issues
• Fix import statements
• Align tests with actual APIs

Week 2: Test Restructuring

• Consolidate test modules
• Fix module dependencies
• Implement missing functionality
• Add proper error handling

Week 3: Validation

• Run full test suite
• Performance testing
• Integration testing
• Documentation updates

Success Criteria

Compilation

• cargo check passes without errors
• cargo test runs successfully
• All test modules compile

Functionality

• Signal cleanup works correctly
• Memory management functions properly
• Batched updates work as expected
• Performance characteristics are acceptable

Testing

• All tests pass
• Test coverage is accurate
• Integration tests work
• Performance benchmarks pass

Risk Mitigation

High Risk

• API Changes: Ensure backward compatibility
• Performance: Monitor signal update performance
• Memory: Prevent memory leaks in cleanup operations

Medium Risk

• Test Coverage: Maintain comprehensive test coverage
• Documentation: Keep documentation up to date

Low Risk

• Import Issues: Standardize import patterns
• Code Style: Maintain consistent code style

Files to Fix

Critical Files

1. packages/signal-management/src/lifecycle_tests/integration_tests.rs
2. packages/signal-management/src/signal_management_tests/mod.rs
3. packages/signal-management/src/simple_tests/mod.rs
4. packages/signal-management/src/memory_management_tests/mod.rs

Supporting Files

1. packages/signal-management/src/lifecycle.rs
2. packages/signal-management/src/batched_updates.rs
3. packages/signal-management/src/memory_management.rs

---

Priority: 🔴 P0 - CRITICAL Estimated Effort: 3 weeks Dependencies: None