rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-19 22:20:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove Layer::dump

Browse Source
This commit is contained in:
Joonas Koivunen
2023-08-22 00:36:29 +03:00
parent b7cb9f43b8
commit 3151ac637c
5 changed files with 0 additions and 35 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
pageserver/src/tenant/storage_layer.rs
View File

@@ -363,9 +363,6 @@ pub trait Layer: std::fmt::Debug + std::fmt::Display + Send + Sync + 'static {
reconstruct_data: &mut ValueReconstructState,
ctx: &RequestContext,
) -> Result<ValueReconstructResult>;
/// Dump summary of the contents of the layer to stdout
async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()>;
}
/// Get a layer descriptor from a layer.

5
pageserver/src/tenant/storage_layer/delta_layer.rs
View File

@@ -239,11 +239,6 @@ impl std::fmt::Debug for DeltaLayerInner {
#[async_trait::async_trait]
impl Layer for DeltaLayer {
/// debugging function to print out the contents of the layer
async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()> {
self.dump(verbose, ctx).await
}
async fn get_value_reconstruct_data(
&self,
key: Key,

5
pageserver/src/tenant/storage_layer/image_layer.rs
View File

@@ -169,11 +169,6 @@ impl std::fmt::Debug for ImageLayerInner {
#[async_trait::async_trait]
impl Layer for ImageLayer {
/// debugging function to print out the contents of the layer
async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()> {
self.dump(verbose, ctx).await
}
/// Look up given page in the file
async fn get_value_reconstruct_data(
&self,

4
pageserver/src/tenant/storage_layer/inmemory_layer.rs
View File

@@ -223,10 +223,6 @@ impl Layer for InMemoryLayer {
self.get_value_reconstruct_data(key, lsn_range, reconstruct_data, ctx)
.await
}
async fn dump(&self, verbose: bool, ctx: &RequestContext) -> Result<()> {
self.dump(verbose, ctx).await
}
}
impl std::fmt::Display for InMemoryLayer {

18
pageserver/src/tenant/storage_layer/remote_layer.rs
View File

@@ -76,24 +76,6 @@ impl Layer for RemoteLayer {
) -> Result<ValueReconstructResult> {
bail!("layer {self} needs to be downloaded");
}
/// debugging function to print out the contents of the layer
async fn dump(&self, _verbose: bool, _ctx: &RequestContext) -> Result<()> {
println!(
"----- remote layer for ten {} tli {} keys {}-{} lsn {}-{} is_delta {} is_incremental {} size {} ----",
self.desc.tenant_id,
self.desc.timeline_id,
self.desc.key_range.start,
self.desc.key_range.end,
self.desc.lsn_range.start,
self.desc.lsn_range.end,
self.desc.is_delta,
self.desc.is_incremental,
self.desc.file_size,
);
Ok(())
}
}
/// Boilerplate to implement the Layer trait, always use layer_desc for persistent layers.