review & identified a cast that isn't handled, document that

This commit is contained in:
Christian Schwarz
2024-11-27 10:33:53 +01:00
parent e0123c8a80
commit 7fb3d95596

View File

@@ -1136,6 +1136,9 @@ impl PageServerHandler {
// - Case 2: If the Reading stage is waiting on its downstream (send to Batching),
// it follows that Batching is waiting for Executor.
// Executor will observe self.cancel when it sends the response, and exit with Err(QueryError::Shutdown).
// - Case 3: the Executor stage observes self.cancel and exits with Err() while the Reading
// stage is waiting for a message from the client. If no message from the client arrives,
// the Reading stage will never exit.
//
// In either case, a task exits, which makes the other tasks in the pipeline exit.
//