rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-17 13:10:38 +00:00
Code Issues Packages Projects Releases Wiki Activity

review pass: found two incorrect Noops

Browse Source
This commit is contained in:
Christian Schwarz
2024-01-04 13:15:48 +00:00
parent c7e50a54da
commit 925f365aa0
1 changed files with 6 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
pageserver/src/walingest.rs
View File

@@ -383,8 +383,10 @@ impl WalIngest {
if self.checkpoint.nextOid != next_oid {
self.checkpoint.nextOid = next_oid;
self.checkpoint_modified = true;
IngestRecordOutcome::Stored
} else {
IngestRecordOutcome::Noop
}
IngestRecordOutcome::Noop // TODO review
} else if info == pg_constants::XLOG_CHECKPOINT_ONLINE
|| info == pg_constants::XLOG_CHECKPOINT_SHUTDOWN
{
@@ -404,8 +406,10 @@ impl WalIngest {
{
self.checkpoint.oldestXid = xlog_checkpoint.oldestXid;
self.checkpoint_modified = true;
IngestRecordOutcome::Stored
} else {
IngestRecordOutcome::Noop
}
IngestRecordOutcome::Noop
} else if info == pg_constants::XLOG_FPI || info == pg_constants::XLOG_FPI_FOR_HINT
{
// These records are importan for us, bu they are handled by