rust/neon
1
0
Fork 0
mirror of https://github.com/neondatabase/neon.git synced 2026-05-18 21:50:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

fixup comment from 'add TODO comment regarding de-configuration of remote storage'

Browse Source
This commit is contained in:
Christian Schwarz
2023-05-03 17:47:11 +02:00
parent 16486edd8e
commit b58bf56670
1 changed files with 10 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

15
pageserver/src/tenant.rs
View File

@@ -1075,11 +1075,16 @@ impl Tenant {
let index_part = match index_part {
MaybeDeletedIndexPart::IndexPart(index_part) => index_part,
MaybeDeletedIndexPart::Deleted => {
/// TODO: we won't reach here if remote storage gets de-configured after start of the deletion operation.
/// Example: start deletion operation, finishes upload of index part, pageserver crashes, remote storage gets de-configured, pageserver starts.
///
/// We don't really anticipate remote storage to be de-configured, so, for now, this is fine.
/// Also, maybe we'll remove that option entirely in the future, see https://github.com/neondatabase/neon/issues/4099.
// TODO: we won't reach here if remote storage gets de-configured after start of the deletion operation.
// Example:
// start deletion operation
// finishes upload of index part
// pageserver crashes
// remote storage gets de-configured
// pageserver starts
//
// We don't really anticipate remote storage to be de-configured, so, for now, this is fine.
// Also, maybe we'll remove that option entirely in the future, see https://github.com/neondatabase/neon/issues/4099.
info!("is_deleted is set on remote, resuming removal of local data originally done by timeline deletion handler");
std::fs::remove_dir_all(
self.conf.timeline_path(&timeline_id, &self.tenant_id),