Commit Graph

2355 Commits

Author SHA1 Message Date
Joonas Koivunen f4fb08d869 stop masking the topmost error in http handler 2024-07-26 14:39:31 +00:00
Joonas Koivunen c23cd5c149 ongoing_detach_ancestor => gc_blocking in index_part 2024-07-26 14:39:31 +00:00
Joonas Koivunen f4cd9fe40b refactor: misc after attempt to add lock_in_reparentable 2024-07-26 14:39:31 +00:00
Joonas Koivunen 43af9484c0 doc: schedule_reparenting_and_wait 2024-07-26 14:39:31 +00:00
Joonas Koivunen 842bd4c2db refactor: reparentable_timelines query out 2024-07-26 14:39:31 +00:00
Joonas Koivunen ada9a46dca remove done fixme, minor reformattting 2024-07-26 14:39:31 +00:00
Joonas Koivunen 742fcac7b9 refactor: use partialeq more 2024-07-26 14:39:31 +00:00
Joonas Koivunen 55aeeb5765 allow deleting timeline unblock gc 2024-07-26 14:39:31 +00:00
Joonas Koivunen 89426570d3 relax overly strict comparisons 2024-07-26 14:39:31 +00:00
Joonas Koivunen 7f767ca18e fix: must_restart condition 2024-07-26 14:39:31 +00:00
Joonas Koivunen 1348dbf0f1 doc: comment cleanup 2024-07-26 14:39:31 +00:00
Joonas Koivunen a179283f86 always notify gc_waiting when writing over the witness tracking 2024-07-26 14:39:31 +00:00
Joonas Koivunen deb86c1ea1 remodel the return type 2024-07-26 14:39:31 +00:00
Joonas Koivunen dfdf40916f rename complete_detaching_from_ancestor
it hasn't meant completing in a while now :)
2024-07-26 14:39:31 +00:00
Joonas Koivunen c6d8015fe9 chore: clippy needless into_iter 2024-07-26 14:39:31 +00:00
Joonas Koivunen ce2552ba67 minor comment update for FIXME about 503 2024-07-26 14:39:31 +00:00
Joonas Koivunen f4d773bb89 refactor: unify t::s::Semaphore 2024-07-26 14:39:31 +00:00
Joonas Koivunen 6f28263428 refactor: failpoint all but one 2024-07-26 14:39:31 +00:00
Joonas Koivunen 1e380ea5af refactor: Ancestor::Delete is not needed 2024-07-26 14:39:31 +00:00
Joonas Koivunen 8258385301 remove indentation level with exhaustive match 2024-07-26 14:39:31 +00:00
Joonas Koivunen 6a8f00dea0 fix: return reparented_direct_children in case we reparent nothing new 2024-07-26 14:39:31 +00:00
Joonas Koivunen 44cdb9fb58 refactor: reparented_direct_children query 2024-07-26 14:39:31 +00:00
Joonas Koivunen cdfaf0700f fix: bifurcate the detach+reparent step 2024-07-26 14:39:31 +00:00
Joonas Koivunen 881e1ad056 refactor: no need to collect reparentable here 2024-07-26 14:39:31 +00:00
Joonas Koivunen bb3d70e24d fix: properly cancel if any reparenting failed 2024-07-26 14:39:31 +00:00
Joonas Koivunen c6c560e4c8 rewrite to include testing assertion 2024-07-26 14:39:31 +00:00
Joonas Koivunen 8dd332aed5 doc: remove unnecessary comment 2024-07-26 14:39:31 +00:00
Joonas Koivunen 5c03a17eb8 wip: some progress
now we hit the todo! in "already detached" path.
2024-07-26 14:39:31 +00:00
Joonas Koivunen 402d66778e make reparenting operations idempotent 2024-07-26 14:39:31 +00:00
Joonas Koivunen 39e2bc932f prepare to reparent while gc blocked 2024-07-26 14:39:31 +00:00
Joonas Koivunen 5fc034fa7f feat: block gc persistently until detach ancestor completes 2024-07-26 14:39:31 +00:00
Joonas Koivunen f9b12def0b add support for WaitToActivate errors 2024-07-26 14:39:31 +00:00
Joonas Koivunen 5d0071447c partial: index_part.json support for ongoing_detach_ancestor 2024-07-26 14:39:31 +00:00
Joonas Koivunen 409e2eff9e fix: run upload_rewritten_layer in a span
there was a weird failure observed with CI tests: https://neon-github-public-dev.s3.amazonaws.com/reports/pr-8430/10108870590/index.html#suites/a1c2be32556270764423c495fad75d47/94a4686382b96297
2024-07-26 14:39:31 +00:00
Joonas Koivunen e6e3b9a716 doc: remove on_gc_task_start fixme 2024-07-26 08:52:55 +00:00
Joonas Koivunen 7f31a3f671 forgotten rename, maybe 2024-07-26 08:52:55 +00:00
Joonas Koivunen 9971ae3d24 rename is_detached_from_{original_,}ancestor (just the rename) 2024-07-26 08:52:55 +00:00
Joonas Koivunen 48a2a20de3 chore: derive default 2024-07-26 08:52:55 +00:00
Joonas Koivunen 29ef8f15ce chore: unused variable 2024-07-26 08:52:55 +00:00
Joonas Koivunen 5e45dd3f86 rename SharedState::notify
to continue_existing_attempt
2024-07-26 08:52:55 +00:00
Joonas Koivunen 5fced442d7 warning caused by removed body 2024-07-26 08:52:55 +00:00
Joonas Koivunen 4222610233 cleanup index part dependent 2024-07-26 08:52:55 +00:00
Joonas Koivunen 92deb0dfd7 plumbing: collect timelines index parts 2024-07-26 08:52:55 +00:00
Joonas Koivunen 46ca6f17c5 plumbing: notify shared state of existing attempt 2024-07-26 08:52:55 +00:00
Joonas Koivunen 14869abb77 complete the plumbing with non-notifying attempt_blocks_gc impl 2024-07-26 08:52:55 +00:00
Joonas Koivunen 5330fd9366 doc(fixme): shared state 2024-07-26 08:52:55 +00:00
Joonas Koivunen 6c5b3b7812 doc: more sketched api comments 2024-07-26 08:52:55 +00:00
Joonas Koivunen 849fe0f191 plumb the shared state through
the api for the gc pausing is quite awkward.
2024-07-26 08:52:55 +00:00
Joonas Koivunen f564b66f21 shared state sketch 2024-07-26 08:52:55 +00:00
Joonas Koivunen 2e58ccee78 temp: planning 2024-07-26 08:52:55 +00:00