Commit Graph

5817 Commits

Author SHA1 Message Date
Joonas Koivunen
f58636ffdd test: refactor -- begin to -funroll-loops in test_retried_detach_ancestor_after_failed_reparenting 2024-07-26 14:39:32 +00:00
Joonas Koivunen
f3ac5bcbe1 test: ensure gc is unpaused with the earlier deletion test 2024-07-26 14:39:32 +00:00
Joonas Koivunen
eb3711b881 doc: why no cancel 2024-07-26 14:39:32 +00:00
Joonas Koivunen
c864166b32 test: make sure gc gets unblocked by late deletion 2024-07-26 14:39:32 +00:00
Joonas Koivunen
ce9b5ae7bf test: allow the 500 error crutch temporarily 2024-07-26 14:39:32 +00:00
Joonas Koivunen
cd2cbe0691 test: rename test_deletion_after_timeline_ancestor_detach_before_completion 2024-07-26 14:39:32 +00:00
Joonas Koivunen
7f241bd379 refactor: remove needless Error::from 2024-07-26 14:39:32 +00:00
Joonas Koivunen
ff52901028 refactor: still_ongoing assert is shared in all paths 2024-07-26 14:39:32 +00:00
Joonas Koivunen
bb377a3544 fixup: make sure detach_ancestor is blocking gc 2024-07-26 14:39:32 +00:00
Joonas Koivunen
5ece7af497 doc: remove confusing comment 2024-07-26 14:39:32 +00:00
Joonas Koivunen
2be3027fa5 doc: elaborate on weird query 2024-07-26 14:39:32 +00:00
Joonas Koivunen
14a0517c7f also assert still ongoing 2024-07-26 14:39:32 +00:00
Joonas Koivunen
dcff25c293 chore: adjust assert message 2024-07-26 14:39:32 +00:00
Joonas Koivunen
f80c37b733 chore: forgotten to update panic text with detach_and_reparent renaming 2024-07-26 14:39:32 +00:00
Joonas Koivunen
b9d0b26cea doc: remove possibly wrong comment 2024-07-26 14:39:32 +00:00
Joonas Koivunen
c2c28f211b doc: explain returning option 2024-07-26 14:39:32 +00:00
Joonas Koivunen
1ebcb1c45b doc: clean out FIXME
we cannot protect against willful misuse. I had been thinking of witness
of Attempt but ...
2024-07-26 14:39:32 +00:00
Joonas Koivunen
66d750ec20 info log on detach 2024-07-26 14:39:32 +00:00
Joonas Koivunen
ba3a6645e7 fix: info log line again, botched rebase? 2024-07-26 14:39:32 +00:00
Joonas Koivunen
8885a8c482 fixup: missed hashset change 2024-07-26 14:39:32 +00:00
Joonas Koivunen
c8880b69fb stop with the (ancestor_lsn, timeline_id) ordered reparented
I was thinking of the case where we have multiple reparented at the same
ancestor_lsn. But of course, that is not a problem if we compare the
reparented as a set...
2024-07-26 14:39:32 +00:00
Joonas Koivunen
274b2a611b test: handle the case where timeline cannot be found
at least do not double-panick.
2024-07-26 14:39:32 +00:00
Joonas Koivunen
a7153bf9b2 test: forgotten allowed errors 2024-07-26 14:39:32 +00:00
Joonas Koivunen
8a4236a441 test: remove needless s3 storage 2024-07-26 14:39:32 +00:00
Joonas Koivunen
7ec927e43b test: cleanup todos 2024-07-26 14:39:32 +00:00
Joonas Koivunen
22470ef444 test: comment 2024-07-26 14:39:32 +00:00
Joonas Koivunen
8248cbb45b test: ensure persisted gc blocking works across restart 2024-07-26 14:39:32 +00:00
Joonas Koivunen
4dd805b68a test: remove the extra deletion which was confusing
it had already been reparented, so it was not needed.
2024-07-26 14:39:32 +00:00
Joonas Koivunen
f582675452 test: refactor repetition 2024-07-26 14:39:32 +00:00
Joonas Koivunen
48069f68bb chore: forgotten pyfmt 2024-07-26 14:39:32 +00:00
Joonas Koivunen
8f52139913 additional assert in completion 2024-07-26 14:39:32 +00:00
Joonas Koivunen
fc4d80bbf2 elaborate on TODO for which a test is later added 2024-07-26 14:39:32 +00:00
Joonas Koivunen
dc83a5a978 fixup dae8c75c04 test: cannot be parametrized over return or exit 2024-07-26 14:39:32 +00:00
Joonas Koivunen
f4fb08d869 stop masking the topmost error in http handler 2024-07-26 14:39:31 +00:00
Joonas Koivunen
75b326faf4 test: complete fixmes 2024-07-26 14:39:31 +00:00
Joonas Koivunen
c23cd5c149 ongoing_detach_ancestor => gc_blocking in index_part 2024-07-26 14:39:31 +00:00
Joonas Koivunen
f4cd9fe40b refactor: misc after attempt to add lock_in_reparentable 2024-07-26 14:39:31 +00:00
Joonas Koivunen
43af9484c0 doc: schedule_reparenting_and_wait 2024-07-26 14:39:31 +00:00
Joonas Koivunen
842bd4c2db refactor: reparentable_timelines query out 2024-07-26 14:39:31 +00:00
Joonas Koivunen
ada9a46dca remove done fixme, minor reformattting 2024-07-26 14:39:31 +00:00
Joonas Koivunen
742fcac7b9 refactor: use partialeq more 2024-07-26 14:39:31 +00:00
Joonas Koivunen
55aeeb5765 allow deleting timeline unblock gc 2024-07-26 14:39:31 +00:00
Joonas Koivunen
89426570d3 relax overly strict comparisons 2024-07-26 14:39:31 +00:00
Joonas Koivunen
7f767ca18e fix: must_restart condition 2024-07-26 14:39:31 +00:00
Joonas Koivunen
1348dbf0f1 doc: comment cleanup 2024-07-26 14:39:31 +00:00
Joonas Koivunen
a179283f86 always notify gc_waiting when writing over the witness tracking 2024-07-26 14:39:31 +00:00
Joonas Koivunen
deb86c1ea1 remodel the return type 2024-07-26 14:39:31 +00:00
Joonas Koivunen
dfdf40916f rename complete_detaching_from_ancestor
it hasn't meant completing in a while now :)
2024-07-26 14:39:31 +00:00
Joonas Koivunen
c6d8015fe9 chore: clippy needless into_iter 2024-07-26 14:39:31 +00:00
Joonas Koivunen
b2233d557b test: complicate to include added paths 2024-07-26 14:39:31 +00:00