starred/openobserve
1
0
Fork 0
mirror of https://github.com/openobserve/openobserve.git synced 2026-11-04 08:09:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: remove traces error and rate value filters (#9617)

Browse Source 
### **PR Type**
Bug fix


___

### **Description**
- Merge Rate and Errors filter chip displays

- Remove redundant Errors start-value span

- Always display Duration time range when set


___



<details> <summary><h3> File Walkthrough</h3></summary>

<table><thead><tr><th></th><th align="left">Relevant
files</th></tr></thead><tbody><tr><td><strong>Bug
fix</strong></td><td><table>
<tr>
  <td>
    <details>
<summary><strong>TracesMetricsDashboard.vue</strong><dd><code>Unify
filter chip display logic</code>&nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp; &nbsp;
&nbsp; </dd></summary>
<hr>

web/src/plugins/traces/metrics/TracesMetricsDashboard.vue

<ul><li>Merged Rate and Errors chips into single time-range
indicator<br> <li> Removed specific Errors value display span<br> <li>
Changed Duration chip to always use time-range v-if</ul>


</details>


  </td>
<td><a
href="https://github.com/openobserve/openobserve/pull/9617/files#diff-7b6f29a2737d9501b18dbd8622eba4965e4bc2b92115627ae7d2e70cc3382087">+2/-5</a>&nbsp;
&nbsp; &nbsp; </td>

</tr>
</table></td></tr></tr></tbody></table>

</details>

___

---------

Co-authored-by: omkark06 <omkar@zinclabs.io>
This commit is contained in:
Bhargav
2025-12-30 12:08:04 +05:30
committed by GitHub
co-authored by omkark06
parent d814b75294
commit 271ff27fac
3 changed files with 8 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/api-testing/tests/test_streaming.py
+2 -2
View File
@@ -213,7 +213,7 @@ def test_histogram(
now = datetime.now(timezone.utc)
end_time = int(now.timestamp() * 1000000)
ten_min_ago = int((now - timedelta(minutes=15)).timestamp() * 1000000) # Increased to 15 minutes to ensure data coverage
ten_min_ago = int((now - timedelta(hours=1)).timestamp() * 1000000) # Increased to 1 hour to ensure data coverage across test runs
json_data_hist = {
"query": {
"sql": hist_query,
@@ -929,7 +929,7 @@ def test_streaming_histogram(
now = datetime.now(timezone.utc)
end_time = int(now.timestamp() * 1000000)
ten_min_ago = int((now - timedelta(minutes=15)).timestamp() * 1000000) # Increased to 15 minutes to ensure data coverage
ten_min_ago = int((now - timedelta(hours=1)).timestamp() * 1000000) # Increased to 1 hour to ensure data coverage across test runs
json_data_hist = {
"query": {
"sql": hist_query,
web/coverage.sh
+4 -4
View File
@@ -2,10 +2,10 @@
set -eu -o pipefail
# Default coverage thresholds - you can override these with environment variables
export FRONTEND_COVERAGE_LINES=${FRONTEND_COVERAGE_LINES:-50}
export FRONTEND_COVERAGE_FUNCTIONS=${FRONTEND_COVERAGE_FUNCTIONS:-40}
export FRONTEND_COVERAGE_BRANCHES=${FRONTEND_COVERAGE_BRANCHES:-40}
export FRONTEND_COVERAGE_STATEMENTS=${FRONTEND_COVERAGE_STATEMENTS:-50}
export FRONTEND_COVERAGE_LINES=${FRONTEND_COVERAGE_LINES:-55}
export FRONTEND_COVERAGE_FUNCTIONS=${FRONTEND_COVERAGE_FUNCTIONS:-44}
export FRONTEND_COVERAGE_BRANCHES=${FRONTEND_COVERAGE_BRANCHES:-45}
export FRONTEND_COVERAGE_STATEMENTS=${FRONTEND_COVERAGE_STATEMENTS:-54}
usage() {
cat <<EOF
web/src/plugins/traces/metrics/TracesMetricsDashboard.vue
+2 -5
View File
@@ -52,13 +52,10 @@ class="tw:mx-1 tw:text-red-500" />
>
<span class="chip-label"
>{{ filter.panelTitle }}
<span v-if="filter.panelTitle === 'Rate'">
<span v-if="filter.panelTitle === 'Rate' || filter.panelTitle === 'Errors'">
: {{ t('latencyInsights.timeRangeSelected') }}
</span>
<span v-else-if="filter.panelTitle === 'Errors'">
>= {{ filter.start }}
</span>
<span v-else-if="filter.panelTitle === 'Duration'">
<span v-if="filter.panelTitle === 'Duration'">
<span v-if="filter.start !== null && filter.end !== null">
{{ formatTimeWithSuffix(filter.start) }} -
{{ formatTimeWithSuffix(filter.end) }}