starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-20 00:03:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(terminal): log pane recovery at warn, not error

Browse Source 
STA-2373 made this path routine: every daemon death now remounts each live
pane, so error level floods logs and crash telemetry with a message that
reports recovery *succeeding*. The breadcrumb right below is what
diagnostics actually consume.
This commit is contained in:
Brennan Benson
2026-07-26 15:08:25 -07:00
parent 1d87f181b4
commit 0628bd1e94
1 changed files with 4 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/terminal-pane/terminal-pane-recovery.ts
+4 -1
View File
@@ -261,7 +261,10 @@ export async function requestTerminalPaneRecovery(request: RecoveryRequest): Pro
// A remount replaces every pane xterm in the tab; a previously scheduled
// retry would only re-remount the fresh, healthy panes.
cancelPendingRecoveryRetry(request.tabId)
console.error(
// warn, not error: this is the recovery succeeding, and the breadcrumb below is
// what diagnostics actually read. STA-2373 made this path routine (every daemon
// death remounts each live pane), so error level just floods logs and telemetry.
console.warn(
`[terminal] recovering pane tab ${request.tabId} — ${request.reason} with a live PTY (${request.ptyId ?? 'unbound'}); remounting to rebuild the renderer`
)
recordRendererCrashBreadcrumb('terminal_pane_recovery_remount', {