fix(cloud): RR-c1 the links read as links at rest (underline), focus ring shown; test props

This commit is contained in:
Neil
2026-11-11 06:22:00 -08:00
parent 5d797cb22a
commit 07ff1fce75
4 changed files with 16 additions and 4 deletions
@@ -26,3 +26,11 @@ export const noGitHubRepositories = defineFixture({
</Column>
)
})
// Keyboard: the link shows its focus ring.
export const focused = defineFixture({
...withGitHubRepositories,
interact: async (frame: HTMLElement) => {
frame.querySelector<HTMLButtonElement>('button')?.focus()
await new Promise((resolve) => setTimeout(resolve, 100))
}
})
@@ -39,9 +39,12 @@ export function OrcaCloudNeedsRepoLine({
size="statusAction"
onClick={hasRepos ? onChooseRepository : onAddRepository}
>
{hasRepos
? t('components.newWorkspace.cloudOnly.chooseRepository', 'Choose repository')
: t('components.newWorkspace.cloudOnly.addRepository', 'Add a GitHub repository')}
{/* Reads as a link at rest, not only on hover (design-squad). */}
<span className="underline underline-offset-4">
{hasRepos
? t('components.newWorkspace.cloudOnly.chooseRepository', 'Choose repository')
: t('components.newWorkspace.cloudOnly.addRepository', 'Add a GitHub repository')}
</span>
</Button>
</div>
</div>
@@ -18,7 +18,7 @@ export function OrcaCloudWallLine({ wall }: { wall: OrcaCloudWallNotice }): Reac
// statusAction pads its label by px-1; the wrapper's -mx-1 puts the text flush-left.
<div className="-mx-1">
<Button type="button" variant="link" size="statusAction" onClick={wall.action.run}>
{wall.action.label}
<span className="underline underline-offset-4">{wall.action.label}</span>
</Button>
</div>
) : (
@@ -33,6 +33,7 @@ describe('Orca Cloud on a plain-folder project (RR-c1)', () => {
const { getByRole } = render(
<NewWorkspaceComposerFooter
onCreate={onCreate}
createError={null}
createDisabled
creating={false}
primaryActionLabel="Create workspace"