Fix browser extension reporting

This commit is contained in:
Jinjing
2026-11-12 22:07:45 -08:00
parent 576f6f6dcb
commit 25e6ee8979
2 changed files with 6 additions and 5 deletions
@@ -142,14 +142,13 @@ export function recordBrowserExtensionInstalled(source: 'web_store' | 'unpacked'
}
}
/** Reported once per launch. */
/** Reported once per launch; a refused report is retried on the next use. */
export function recordBrowserExtensionUsed(): void {
if (usedThisSession) {
return
}
usedThisSession = true
try {
track('browser_extension_used', {})
usedThisSession = track('browser_extension_used', {})
} catch {
// Telemetry never costs a click.
}
@@ -343,9 +343,11 @@ describe('useBrowserExtensionsTour banner assignment', () => {
it('does not show once a dialog opened while main was answering', async () => {
let answer: (reply: Reply) => void = () => {}
window.api.telemetryAssignBrowserExtensionsBanner = () =>
new Promise((resolve) => (answer = resolve))
const assign = vi.fn(() => new Promise<Reply>((resolve) => (answer = resolve)))
window.api.telemetryAssignBrowserExtensionsBanner = assign
renderHook(() => useBrowserExtensionsTour(true, true))
await act(async () => vi.advanceTimersByTimeAsync(0))
expect(assign).toHaveBeenCalledTimes(1)
act(() => useAppStore.setState({ activeModal: 'add-repo' }))
await act(async () => {
answer({ status: 'not_enrolled' })