starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-10-23 00:03:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(ssh): narrow why the E2E strengthening patch fails at runtime

Browse Source 
The verified patch that would close both stated E2E weaknesses applies cleanly
but fails locating the tab element. The attribute is not the problem —
SortableTab.tsx:220 renders data-tab-id={tab.id}. Terminal tabs carry both an id
and an entityId, and getTabBarOrder returns entityId, so a locator built from
that order can never match. The fix is to resolve tab.id before clicking.

Recorded in the spec beside the weakness it would close, so the next attempt
starts from the diagnosis rather than rediscovering it.
This commit is contained in:
Neil
2026-08-13 23:36:38 -07:00
parent 9ef7cd097f
commit 26307e63dc
1 changed files with 5 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/e2e/ssh-partition-upgrade-tab-restore.spec.ts
+5 -3
View File
@@ -153,9 +153,11 @@ test.describe('an upgrading profile keeps the tabs its old build left in the ssh
// panes, so this covers one of the three tabs — two could restore blank and this still
// passes. Assertion 3 is weaker still: a bare shell count is satisfied by N killed and N
// respawned, so it cannot show the panes reattached to the SAME shells. A verified patch
// exists that clicks each tab and compares ptyIds captured before quit; it did not apply
// cleanly here (its [data-tab-id] locator does not resolve in this tree) and is left for a
// follow-up rather than landed red.
// exists that clicks each tab and compares ptyIds captured before quit. It applies but fails
// at runtime here, and the cause is narrowed: the attribute is fine — SortableTab.tsx:220
// renders data-tab-id={tab.id} — so the mismatch is WHICH id the helper feeds it. Terminal
// tabs carry both an id and an entityId, and getTabBarOrder returns entityId, so a locator
// built from that order finds nothing. Resolve tab.id (not entityId) before clicking.
await expect
.poll(
async () => {