mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 08:03:13 +00:00
fix(macos): attribute the FDA prompts to agent activity, not Orca's own reads
The card said the prompts happen "when this copy of Orca reads protected app data", but Orca's own reads are small and gated; #9756's trigger is agent find/grep sweeps into ~/Library/Containers, which macOS bills to Orca because Orca is the responsible process for every terminal child. Blaming Orca reads as an accusation and hid why FDA works at all — the grant attaches to Orca rather than to each churning child binary. Name agents as the trigger, keep the "reduce" hedge and the terminal caveat, and drop the "this copy of Orca" dev-build hedge that cost a clause. Assert the causation wording so it can't silently regress.
This commit is contained in:
@@ -131,8 +131,10 @@ describe('FullDiskAccessNudge', () => {
|
||||
expect(container.textContent).toContain('Full Disk Access')
|
||||
expect(container.textContent).toContain('Open System Settings')
|
||||
// The grant covers this app, not the detached PTY daemon that owns terminals.
|
||||
expect(container.textContent).toContain('Terminal sessions may still prompt separately')
|
||||
expect(container.textContent).toContain('may still prompt separately')
|
||||
expect(container.textContent).not.toContain('stops asking')
|
||||
// Agent sweeps trigger these prompts; macOS only names Orca as the responsible process.
|
||||
expect(container.textContent).toContain('agents it runs')
|
||||
})
|
||||
|
||||
it('stays hidden while the probe is unresolved (no first-paint flash)', async () => {
|
||||
|
||||
@@ -258,7 +258,7 @@ export function FullDiskAccessNudge(): React.JSX.Element | null {
|
||||
<p className="mt-1 text-xs leading-snug text-muted-foreground">
|
||||
{translate(
|
||||
'auto.components.sidebar.FullDiskAccessNudge.body',
|
||||
'Grant Full Disk Access to reduce repeated macOS prompts when this copy of Orca reads protected app data. Terminal sessions may still prompt separately.'
|
||||
"These prompts come from Orca and the agents it runs reading other apps' data. Full Disk Access reduces them; terminal sessions may still prompt separately."
|
||||
)}
|
||||
</p>
|
||||
<Button
|
||||
|
||||
@@ -4835,7 +4835,7 @@
|
||||
"title": "Reduce macOS permission prompts",
|
||||
"dismissAriaLabel": "Dismiss Full Disk Access suggestion",
|
||||
"dismiss": "Dismiss",
|
||||
"body": "Grant Full Disk Access to reduce repeated macOS prompts when this copy of Orca reads protected app data. Terminal sessions may still prompt separately.",
|
||||
"body": "These prompts come from Orca and the agents it runs reading other apps' data. Full Disk Access reduces them; terminal sessions may still prompt separately.",
|
||||
"opening": "Opening…",
|
||||
"openSystemSettings": "Open System Settings"
|
||||
}
|
||||
|
||||
@@ -4812,7 +4812,7 @@
|
||||
"title": "Reduce macOS permission prompts",
|
||||
"dismissAriaLabel": "Dismiss Full Disk Access suggestion",
|
||||
"dismiss": "Dismiss",
|
||||
"body": "Grant Full Disk Access to reduce repeated macOS prompts when this copy of Orca reads protected app data. Terminal sessions may still prompt separately.",
|
||||
"body": "These prompts come from Orca and the agents it runs reading other apps' data. Full Disk Access reduces them; terminal sessions may still prompt separately.",
|
||||
"opening": "Opening…",
|
||||
"openSystemSettings": "Open System Settings"
|
||||
}
|
||||
|
||||
@@ -4812,7 +4812,7 @@
|
||||
"title": "Reduce macOS permission prompts",
|
||||
"dismissAriaLabel": "Dismiss Full Disk Access suggestion",
|
||||
"dismiss": "Dismiss",
|
||||
"body": "Grant Full Disk Access to reduce repeated macOS prompts when this copy of Orca reads protected app data. Terminal sessions may still prompt separately.",
|
||||
"body": "These prompts come from Orca and the agents it runs reading other apps' data. Full Disk Access reduces them; terminal sessions may still prompt separately.",
|
||||
"opening": "Opening…",
|
||||
"openSystemSettings": "Open System Settings"
|
||||
}
|
||||
|
||||
@@ -4812,7 +4812,7 @@
|
||||
"title": "Reduce macOS permission prompts",
|
||||
"dismissAriaLabel": "Dismiss Full Disk Access suggestion",
|
||||
"dismiss": "Dismiss",
|
||||
"body": "Grant Full Disk Access to reduce repeated macOS prompts when this copy of Orca reads protected app data. Terminal sessions may still prompt separately.",
|
||||
"body": "These prompts come from Orca and the agents it runs reading other apps' data. Full Disk Access reduces them; terminal sessions may still prompt separately.",
|
||||
"opening": "Opening…",
|
||||
"openSystemSettings": "Open System Settings"
|
||||
}
|
||||
|
||||
@@ -4812,7 +4812,7 @@
|
||||
"title": "Reduce macOS permission prompts",
|
||||
"dismissAriaLabel": "Dismiss Full Disk Access suggestion",
|
||||
"dismiss": "Dismiss",
|
||||
"body": "Grant Full Disk Access to reduce repeated macOS prompts when this copy of Orca reads protected app data. Terminal sessions may still prompt separately.",
|
||||
"body": "These prompts come from Orca and the agents it runs reading other apps' data. Full Disk Access reduces them; terminal sessions may still prompt separately.",
|
||||
"opening": "Opening…",
|
||||
"openSystemSettings": "Open System Settings"
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user