starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-23 00:02:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "fix: pr-bug-scan findings from #1468" (#1559) (#1636)

Browse Source 
Co-authored-by: orca-bot <bot@stably.ai>
This commit is contained in:
buf0-bot[bot]
2026-05-09 17:40:48 -07:00
committed by GitHub
co-authored by orca-bot
parent 1736f08dc7
commit 2b133972fa
1 changed files with 5 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/TaskPage.tsx
+5 -9
View File
@@ -785,18 +785,14 @@ export default function TaskPage(): React.JSX.Element {
}
}, [pageData.taskSource])
// Why: when settings hydrate after Tasks mounts, seed taskSource from
// defaultTaskSource — but only once. Re-running on every defaultTaskSource
// change would clobber an in-session manual source pick (e.g. the user
// clicked the Linear icon and then changed the default in Settings).
const defaultTaskSourceSeededRef = useRef(false)
// Why: settings.defaultTaskSource can change while Tasks is open (Settings
// panel is reachable without unmounting Tasks). The one-shot resume effect
// only seeds taskSource on first mount, so without this sync a mid-session
// change to the default would not propagate when no explicit page-level
// taskSource was passed.
useEffect(() => {
if (defaultTaskSourceSeededRef.current) {
return
}
if (!pageData.taskSource && settings?.defaultTaskSource) {
setTaskSource(settings.defaultTaskSource)
defaultTaskSourceSeededRef.current = true
}
}, [settings?.defaultTaskSource, pageData.taskSource])