starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-24 08:02:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(windows): put the superseded export-only gate in the past tense

Browse Source 
It describes what used to pass a broken addon, so present tense reads as a
description of the gate the same document then explains replacing it.
This commit is contained in:
Neil
2026-09-15 22:38:23 -07:00
parent ad0ccf83a8
commit 2d623d704f
1 changed files with 7 additions and 6 deletions
Download Patch File Download Diff File Expand all files Collapse all files
docs/reference/windows-msys-job-breakaway.md
+7 -6
View File
@@ -75,12 +75,13 @@ to retry for it. That needs a helper that calls `CreateProcess` with the flag;
## A stale addon looks exactly like the bug
`config/scripts/node-pty-job-ownership.cjs` asserts only that `terminateJob`,
`listJobProcessIds` and `assignCurrentProcessToJob` are exported. All three
predate #19068, so a `conpty.node` built before it passes every gate,
`isPtyJobOwnershipAvailable()` returns true, `windows-pty-job.win32.test.ts`
passes 6/6 — and `windows-msys-job.win32.test.ts` fails with a two-pid job list
that reads as a source defect rather than a build-freshness one.
`config/scripts/node-pty-job-ownership.cjs` used to assert only that
`terminateJob`, `listJobProcessIds` and `assignCurrentProcessToJob` are
exported. All three predate #19068, so a `conpty.node` built before it passed
every gate: `isPtyJobOwnershipAvailable()` returned true and
`windows-pty-job.win32.test.ts` passed 6/6, while
`windows-msys-job.win32.test.ts` failed with a two-pid job list that read as a
source defect rather than a build-freshness one.
When that test fails, check the binary before the code: