refactor(settings): narrow retained editor element types

This commit is contained in:
Jinjing
2026-11-13 16:34:36 -08:00
parent a3b60b3035
commit 36bd64e689
2 changed files with 4 additions and 5 deletions
@@ -71,7 +71,7 @@ it('retains a focused unsaved command and selection across asynchronous membersh
const save = vi.fn()
const view = render(catalog(false, save))
fireEvent.click(screen.getByRole('button', { name: 'Claude' }))
const input = screen.getByDisplayValue('claude') as HTMLInputElement
const input = screen.getByDisplayValue<HTMLInputElement>('claude')
input.focus()
fireEvent.change(input, { target: { value: '/custom/unsaved-claude' } })
input.setSelectionRange(3, 9, 'backward')
@@ -109,7 +109,7 @@ it('keeps a pending save attached to the same editor when membership changes', a
)
const view = render(catalog(false, save))
fireEvent.click(screen.getByRole('button', { name: 'Claude' }))
const input = screen.getByDisplayValue('claude') as HTMLInputElement
const input = screen.getByDisplayValue<HTMLInputElement>('claude')
fireEvent.change(input, { target: { value: '/custom/claude' } })
fireEvent.keyDown(input, { key: 'Enter' })
await waitFor(() => expect(input.readOnly).toBe(true))
@@ -29,9 +29,8 @@ export function createAgentCatalogRowHost(): {
}
const atomic =
element.isConnected && parent.isConnected && typeof parent.moveBefore === 'function'
const active = element.contains(document.activeElement)
? (document.activeElement as HTMLElement)
: null
const focused = document.activeElement
const active = focused instanceof HTMLElement && element.contains(focused) ? focused : null
const selection =
active instanceof HTMLInputElement || active instanceof HTMLTextAreaElement
? {