starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-28 00:02:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

docs(windows): say the arch proxy is superseded, not complementary

Browse Source 
Both the removed `electronArch === process.arch` check and `conptyTargetsArch`
answer one question: does build/Release hold a binary this slice can load.
Re-adding the proxy alongside the header read as insurance would restore the
skip the header read exists to close -- the arm64 slice cross-built on x64.

Recorded at the guard because a reviewer cannot see a silently-preferred wrong
guard in a diff where both fixes appear to have landed.
This commit is contained in:
Neil
2026-09-11 00:06:03 -07:00
parent d8530f7a10
commit 4a0602e69f
1 changed files with 4 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files
config/packaged-runtime-node-modules.cjs
+4
View File
@@ -395,6 +395,10 @@ function prunePackagedNodePty(resourcesDir, electronPlatformName, electronArch)
// that with `electronArch === process.arch`, which also skipped the arm64 slice cross-built on
// an x64 Windows host -- a rebuild that DOES produce a correct arm64 addon. That slice then
// shipped the unpatched prebuild as a live fallback. Read the header instead of guessing.
//
// The proxy is SUPERSEDED, not complementary: both answer "does build/Release hold a binary
// this slice can load", and re-adding `electronArch === process.arch` alongside this as
// insurance would restore the skip in the exact case the header read exists to cover.
if (electronPlatformName === 'win32') {
const releaseAddon = join(nodePtyDir, 'build', 'Release', 'conpty.node')
if (conptyTargetsArch(releaseAddon, electronArch)) {