starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-22 00:02:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

feat: show persistent underline on PR link buttons in review headers (#4861)

Browse Source
This commit is contained in:
Jinjing
2026-06-07 20:51:04 -07:00
committed by GitHub
parent 468244d6dc
commit 4a3db11e16
4 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/renderer/src/components/right-sidebar/ChecksPanel.review-header.test.tsx
+1
View File
@@ -48,6 +48,7 @@ describe('ChecksPanelReviewHeader', () => {
expect(markup).toContain('Open on GitHub')
expect(markup).toContain('#2964')
expect(markup).toContain('underline decoration-border underline-offset-2')
expect(markup).toContain('More PR actions')
expect(markup).toContain('unlink PR')
expect(markup).toContain('Link another PR')
src/renderer/src/components/right-sidebar/ChecksPanel.tsx
+1 -1
View File
@@ -139,7 +139,7 @@ export function ChecksPanelReviewHeader({
<ReviewIcon className="size-4 text-muted-foreground shrink-0" />
<button
type="button"
className="rounded px-0.5 text-[12px] font-semibold text-foreground underline-offset-2 hover:text-foreground hover:underline focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
className="rounded px-0.5 text-[12px] font-semibold text-foreground underline decoration-border underline-offset-2 hover:text-foreground hover:decoration-foreground focus-visible:outline-none focus-visible:ring-1 focus-visible:ring-ring"
title={`Open on ${reviewHostLabel}`}
onClick={onOpenReview}
>
src/renderer/src/components/right-sidebar/SourceControl.hosted-review-header-link.test.tsx
+1
View File
@@ -31,6 +31,7 @@ describe('HostedReviewHeaderLink', () => {
expect(markup).toContain('<button')
expect(markup).toContain('PR #2192')
expect(markup).toContain('underline decoration-border underline-offset-2')
expect(markup).not.toContain('href=')
expect(markup).not.toContain('target="_blank"')
src/renderer/src/components/right-sidebar/SourceControl.tsx
+1 -1
View File
@@ -1004,7 +1004,7 @@ export function HostedReviewHeaderLink({
}): React.JSX.Element {
const label = hostedReviewLabel(review)
const className =
'shrink-0 border-0 bg-transparent p-0 text-left font-medium leading-none text-foreground opacity-80 hover:text-foreground hover:underline'
'shrink-0 border-0 bg-transparent p-0 text-left font-medium leading-none text-foreground underline decoration-border underline-offset-2 opacity-80 hover:text-foreground hover:decoration-foreground'
if (review.provider === 'github' || review.provider === 'gitlab') {
return (