perf: reuse mounted ref in resource usage status (#3595)

This commit is contained in:
Neil
2026-05-30 03:05:44 -07:00
committed by GitHub
parent c5c4ca5b5c
commit 4d4f0dca2a
@@ -28,6 +28,7 @@ import {
DialogTitle
} from '@/components/ui/dialog'
import { cn } from '@/lib/utils'
import { useMountedRef } from '@/hooks/useMountedRef'
import { activateAndRevealWorktree } from '@/lib/worktree-activation'
import { activateTabAndFocusPane } from '@/lib/activate-tab-and-focus-pane'
import { installWindowVisibilityInterval } from '@/lib/window-visibility-interval'
@@ -695,7 +696,7 @@ export function ResourceUsageStatusSegment({
// somewhere stable for keyboard users.
const popoverBodyRef = useRef<HTMLDivElement | null>(null)
const popoverBodyFocusFrameRef = useRef<number | null>(null)
const mountedRef = useRef(true)
const mountedRef = useMountedRef()
const cancelPopoverBodyFocusFrame = useCallback((): void => {
if (popoverBodyFocusFrameRef.current === null) {
@@ -707,13 +708,6 @@ export function ResourceUsageStatusSegment({
useEffect(() => cancelPopoverBodyFocusFrame, [cancelPopoverBodyFocusFrame])
useEffect(() => {
mountedRef.current = true
return () => {
mountedRef.current = false
}
}, [])
const setPopoverBodyNode = useCallback(
(node: HTMLDivElement | null): void => {
// Why: the queued post-kill focus is only valid while the popover body exists.
@@ -745,7 +739,7 @@ export function ResourceUsageStatusSegment({
setSessionsError(true)
}
}
}, [runtimeEnvironmentActive])
}, [mountedRef, runtimeEnvironmentActive])
const daemonActions = useDaemonActions({
onRestartSettled: () => {
@@ -1096,7 +1090,7 @@ export function ResourceUsageStatusSegment({
void refreshSessions()
}
}
}, [cancelPopoverBodyFocusFrame, killConfirm, refreshSessions])
}, [cancelPopoverBodyFocusFrame, killConfirm, mountedRef, refreshSessions])
const openSpaceResults = useCallback((): void => {
setOpen(false)