test(ssh): state plainly that the reconnect spec is a forward guard

It was run against an unfixed tree and passed, so it does not prove the
STA-3077 fixes and should not be read as if it does. A clean severed
transport does not reproduce the field conditions — accumulated duplicate
leases, or a source returning needing re-establishment.

It keeps its place as a forward guard: it counts the shells the relay
actually hosts and pins their PIDs, so a later change that grafts a pane
or respawns a shell fails here.

Co-authored-by: Orca <help@stably.ai>
This commit is contained in:
Neil
2026-08-08 19:11:53 -07:00
co-authored by Orca
parent 356d6b52b2
commit 67701bfa14
@@ -1,3 +1,18 @@
/**
* Forward regression guard for pane and remote-PTY cardinality across
* reconnects, run against a real OpenSSH container.
*
* Scope, stated honestly: this spec passes both with and without the STA-3077
* fixes — it was run against an unfixed tree and did not fail. A clean severed
* transport reconnects without producing the conditions that grafted panes in
* the field, which needed accumulated duplicate leases or a source that came
* back needing re-establishment. So it does NOT prove those fixes; the oracles
* that do are in `src/main/ssh-reattach-pane-cardinality.test.ts`.
*
* It still earns its place: it counts the shells the relay actually hosts, on
* the container, and pins their PIDs — so a future change that grafts a pane or
* kills and respawns a shell fails here.
*/
import type { Page, TestInfo } from '@stablyai/playwright-test'
import { test, expect } from './helpers/orca-app'
import { ensureTerminalVisible, waitForActiveWorktree, waitForSessionReady } from './helpers/store'