mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 08:03:13 +00:00
fix(terminal): correct recovery log comment and test console spy
The comment claimed error level floods telemetry; nothing forwards renderer console into telemetry, and the breadcrumb below is untouched, so this change alters telemetry volume by zero. The test's console.error spy silenced the old call site and now stubs nothing, leaking 26 stderr lines under verbose.
This commit is contained in:
@@ -34,7 +34,7 @@ beforeEach(() => {
|
||||
vi.stubGlobal('window', {
|
||||
api: { pty: { hasPty: mocks.hasPty } }
|
||||
})
|
||||
vi.spyOn(console, 'error').mockImplementation(() => {})
|
||||
vi.spyOn(console, 'warn').mockImplementation(() => {})
|
||||
})
|
||||
|
||||
afterEach(() => {
|
||||
|
||||
@@ -263,7 +263,7 @@ export async function requestTerminalPaneRecovery(request: RecoveryRequest): Pro
|
||||
cancelPendingRecoveryRetry(request.tabId)
|
||||
// warn, not error: this is the recovery succeeding, and the breadcrumb below is
|
||||
// what diagnostics actually read. STA-2373 made this path routine (every daemon
|
||||
// death remounts each live pane), so error level just floods logs and telemetry.
|
||||
// death remounts each live pane), so error level just floods the logs.
|
||||
console.warn(
|
||||
`[terminal] recovering pane tab ${request.tabId} — ${request.reason} with a live PTY (${request.ptyId ?? 'unbound'}); remounting to rebuild the renderer`
|
||||
)
|
||||
|
||||
Reference in New Issue
Block a user