starred/orca
1
0
Fork 0
mirror of https://github.com/stablyai/orca.git synced 2026-09-24 16:02:41 +00:00
Code Issues Packages Projects Releases Wiki Activity

test(orchestration): name the migration-revert helper for its domain role

Browse Source 
The rename to revertToV41Shape tripped the naming audit — "shape" describes
structure rather than what the helper does, which is undo the principal migration.
This commit is contained in:
Brennan Benson
2026-09-16 16:57:58 -07:00
parent 49a7083176
commit 7b46cc4aef
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/main/runtime/orchestration/db/schema/principal-column-migration.test.ts
+3 -3
View File
@@ -12,8 +12,8 @@ const LEAF2 = '22222222-2222-4222-8222-222222222222'
const LEAF3 = '33333333-3333-4333-8333-333333333333'
const STRUCTURED_PANE = `structured-agent-session-sess1:${LEAF2}`
/** Puts an already-migrated database back into pre-principal (v41) shape for the direct-unit cases. */
function revertToV41Shape(db: OrchestrationDb): void {
/** Undoes the principal migration so the direct-unit cases start from a v41 database. */
function revertPrincipalMigration(db: OrchestrationDb): void {
db.db.exec(`
DROP TRIGGER IF EXISTS trg_runs_remember_coordinator_insert;
DROP TRIGGER IF EXISTS trg_runs_remember_coordinator_update;
@@ -71,7 +71,7 @@ describe('principal column migration', () => {
it('v41 -> v42 migrates and backfills by classification, and is idempotent', () => {
const db = new OrchestrationDb(':memory:')
try {
revertToV41Shape(db)
revertPrincipalMigration(db)
seedV41Rows(db)
migrateV42.call(db, 41)