mirror of
https://github.com/stablyai/orca.git
synced 2026-10-06 08:02:28 +00:00
docs(native-chat): correct a test title, simplify the alias, escape the path
Review pass 4 came back clean; these are its three nits, all zero-behaviour. The read-restore test titled its fixture "a compacted remnant … has no log beside it", which is false — `rewriteJournalLog` always rewrote `log.jsonl`, so a compacted directory has both files. The fixture is still worth having as the log-is-gone case; only the title was wrong, a framing left over from before the source comment was corrected to the measured argument. `JournalDisclosure` is just `JournalRepairDisclosure`; two indexed accesses said the same thing at more length. The transcript path is interpolated into text that renders through `CommentMarkdown`, so a home directory containing underscores would have emphasised a segment of it. Backticked. The path still linkifies — the file-link plugin handles `inlineCode` nodes as well as text.
This commit is contained in:
@@ -53,7 +53,7 @@ export function journalFileFormatRemnantDisclosure(input: {
|
||||
`This chat's history was saved in an older format Orca no longer reads, so it starts ` +
|
||||
`empty. The session still points at the same ${formatAgentTypeLabel(input.agent)} ` +
|
||||
`conversation — send a message to pick up where you left off. The original ` +
|
||||
`transcript is on the session's host at ${input.transcriptPath}`
|
||||
`transcript is on the session's host at \`${input.transcriptPath}\``
|
||||
)
|
||||
}
|
||||
}
|
||||
|
||||
@@ -9,10 +9,7 @@ import { journalRepairDisclosure, type JournalRepairDisclosure } from './journal
|
||||
|
||||
/** What any of this file's disclosures hands the store — a repair's, or the
|
||||
* pre-SQLite notice's. Same shape, and neither is only a repair. */
|
||||
type JournalDisclosure = {
|
||||
identity: JournalRepairDisclosure['identity']
|
||||
body: JournalRepairDisclosure['body']
|
||||
}
|
||||
type JournalDisclosure = JournalRepairDisclosure
|
||||
|
||||
export async function ensureJournalDir(journalDir: string): Promise<void> {
|
||||
await mkdir(journalDir, { recursive: true })
|
||||
|
||||
+1
-1
@@ -85,7 +85,7 @@ describe('a session whose journal is still the pre-SQLite format', () => {
|
||||
expect(restored!.hasProviderChild).toBe(false)
|
||||
})
|
||||
|
||||
it('is published for a compacted remnant too, which has no log beside it', async () => {
|
||||
it('is published for a remnant whose log is gone', async () => {
|
||||
await writeRemnant('snapshot.json')
|
||||
|
||||
const restored = await restoreStructuredAgentSessionRead(store, journalRoot, SESSION_ID)
|
||||
|
||||
Reference in New Issue
Block a user