mirror of
https://github.com/stablyai/orca.git
synced 2026-10-19 16:03:26 +00:00
style: trim review comments to the one-line house rule
Both explained the change adequately in two lines; the extra lines were worked examples, not information.
This commit is contained in:
@@ -14,9 +14,8 @@ beforeEach(() => {
|
||||
openHttpLinkMock.mockReset()
|
||||
})
|
||||
|
||||
// Why: the preview half of this same decision is pinned with an identical options
|
||||
// shape in markdown-preview-links.test.ts — the two together keep the editor and
|
||||
// preview of one file from routing a link two different ways.
|
||||
// Why: markdown-preview-links.test.ts pins the preview half with the same options
|
||||
// shape, so together they stop one file's link routing two ways.
|
||||
function clickExternalLinkWithShift(sourceOwner: HttpLinkSourceOwner, isMac = true): boolean {
|
||||
const href = 'https://example.com/docs'
|
||||
const view = {
|
||||
|
||||
@@ -16,11 +16,8 @@ function getDefaultBrowserShortcutPlatform(): BrowserShortcutPlatform {
|
||||
}
|
||||
}
|
||||
|
||||
// Why: the modifier sentence moved to the nested "Hold Shift to open in …" row.
|
||||
// Once that row can invert the routing, no single sentence here is true in every
|
||||
// state — "always uses your system browser" breaks when inverting is on, and
|
||||
// "opens a link the other way" breaks in the default state where it is off. The
|
||||
// chord is now stated only by the child row, which knows the live destination.
|
||||
// Why: no fixed modifier sentence is true in every state once inverting exists, so
|
||||
// the nested row states the chord instead — it knows the live destination.
|
||||
export function getBrowserLinkRoutingDescription(): string {
|
||||
return "Open http(s) links in Orca's built-in browser — from the terminal, markdown, and the editor."
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user