Files
orca/config/scripts
06008d20df fix(i18n): select whole count sentences at twelve more call sites (#27974)
* fix(i18n): select whole count sentences at twelve more call sites

Twelve strings were a noun plus a plural ending passed as an
interpolation value, so every non-English locale got a Latin "s" glued
to its own noun whenever the count was not one. Each call site now
chooses between two whole sentences with a single {{count}}, the same
Singular/Plural pattern #27907 uses for three Settings strings.

ja, ko and zh drop the stray ending. es and fr keep what they rendered
for one and get grammatical plural sentences. The "commits ahead"
tooltip in the compare summary takes the wording the catalogs already
have for the identical sentence, because three translations treated the
ending as an object. Legacy keys stay in the catalogs.

Fixes #27973

* fix(i18n): name commits in Korean in the compare-summary tooltip

The Korean pair for the "commits ahead" tooltip was copied from
compareBaseCommitsAheadOne/Other, which keep the English "commit" and
"commits". Both sentences now say 커밋 with the 개 counter, the form
#27907 uses for its Korean count sentences, so the tooltip no longer
carries an English plural.

The locale test also requires ja, ko and zh to use one sentence for
both counts. It fails on the previous Korean pair.

* fix(i18n): take the Korean count sentences from the audit review

Eleven of the twelve Korean pairs still put the number before the noun
with no counter ("3 라벨"), the order left over from dropping the
English plural ending. They now read noun, number, counter
("라벨 3개", "멤버 3명"), the wording abruption supplied in review of
#27974. The "commits ahead" pair already had that form and is unchanged.

Three sentences are also reworded to follow the English: a failed
discard no longer says the files could not be deleted, the group toast
says how many of the contained projects remained, and "restricted key"
is spelled out as an API key with restricted access.

The 22 values are recorded in locale-ko-key-overrides.json, next to the
other reviewed Korean strings.

* chore(i18n): credit the Korean count sentences to their reviewer

The Korean wording applied in f6bbcaf341 was supplied by abruption as a
patch in review of #27974 and went in byte for byte. That commit could
not carry a co-author trailer, so this empty one does.

Co-authored-by: YEONGUK LEE <contact@abruption.dev>

* fix(i18n): drop the twelve keys the count sentences replaced

No call site reads the twelve noun-plus-ending keys any more, so they
leave the six catalogs, as #28185 did for the keys it replaced. With
them go the three Korean override entries for those keys and the one
value ko-ui-semantic-mistranslations.test.ts pinned for the old
sshImportSynced text; the sentence it guarded is now the
sshImportSyncedSingular/Plural pair, covered by
count-sentence-locales.test.ts. en-runtime-required.json is
regenerated.

* fix(i18n): give remote drop uploads their own count keys; drop low-value tests

- Remote terminal drop uploads used the runtime keys with a different
  fallback ('to remote…'); split them into uploadingFileToRemote{Singular,Plural}
  with translations in all catalogs.
- Remove mock-translate tests and the catalog-pinning count-sentence test;
  verify:localization-* already enforces key and placeholder parity.
- Trim the 'why whole sentences' comments.
- Regenerate en-runtime-required.json.

* fix(i18n): natural zh/ja count strings and es host-import wording

---------

Co-authored-by: YEONGUK LEE <contact@abruption.dev>
Co-authored-by: OrcaWin <293788423+OrcaWin@users.noreply.github.com>
2026-10-27 18:00:21 -07:00
..