mirror of
https://github.com/warmbly/warmbly.git
synced 2026-09-06 16:01:28 +00:00
* feat: index advisor findings by subject and parent entity so a list page fetches its whole surface once and every row resolves its own advice from the shared cache instead of firing a request per row * feat: rebuild the advisor fix drawer as a three-screen resolution flow (why it fired with the measured evidence, the exact before and after, then an animated outcome with undo) with a progress rail and direction-aware transitions, and deep-link manual fixes to the screen where they are made * feat: add AdvisorRowFlag, the inline per-row advisor indicator that renders on the mailbox or campaign the problem is about and opens that row's findings in an anchored panel instead of making the reader join a card list against a table * feat: add AdvisorSummaryBar, a one-line collapsible page summary that replaces the stack of advisor cards above a list, counts the distinct rows implicated rather than the findings, and forces itself open only for critical or workspace-level advice no row flag can carry * feat: put advisor advice on the mailbox row it is about in the accounts list, replace the card stack above the table with the collapsible summary bar, and support ?mailbox=<id> so a finding can deep-link straight to the mailbox detail instead of the top of the list * feat: flag advisor findings on the campaign row in the campaigns list, including step-level copy problems which index onto their parent campaign since a step has no row of its own, and add the collapsible summary bar above the list * feat: move the deliverability and contacts pages onto the collapsible advisor summary bar so their findings stop pushing the numbers they describe below the fold * feat: add an ordered Steps field to advisor findings, persisted as text[] and always refreshed from the current build, and write real how-to steps for the deliverability checks that have no one-click fix (bounce rate, spam placement, tracking domain, and per-record SPF/DKIM/DMARC instructions) * feat: write ordered how-to steps for the manual advisor findings where the remedy alone leaves someone stuck (broken template syntax, missing first-name fallback, unsubscribed contacts still enrolled, a campaign with no resolvable sender, and a mailbox that lost warmup pool standing) and correct the personalization detail that named a merge syntax this product does not use * feat: show a mailbox's advisor findings at the top of its detail drawer, which is where both the row flag and the ?mailbox deep link now land * feat: open the resolution flow from findings that have no one-click fix too, since the ordered how-to lives there and a card with no Fix button previously left the steps unreachable * docs: document the per-row advisor flags, the collapsible page summary, the three-screen resolution flow, and the ordered manual steps for findings with no one-click fix * feat: align the advisor summary bar to the px-5 page gutter used by SectionBar and the list rows on all four surfaces, instead of sitting flush against the edge while the table it describes is indented * fix: stop the resolution drawer collapsing to zero height between screens by switching the step transition to popLayout with a layout-animated container, so the dialog resizes into the next screen instead of snapping shut and reopening * feat: wire the advisor repository, narrator, service, tool registration, and background runner into the backend boot path so findings evaluate on a schedule and the assistant can read them * docs: register the advisor guide in the sidebar, add its endpoint scope table to the API reference, and document the sandbox advisor showcase * fix: darken the advisor nav badge to solid orange-600 on white instead of a pale amber-100 chip that read as a disabled control beside the sidebar's saturated indicators, and drop the critical badge to rose-600 so the two stay in the same weight class * fix: use orange-500 for the advisor nav badge, matching the high-severity dot on the row it points at, rather than the darker orange-600 * feat: add an Auto safety class to advisor actions and mark the seven fixes autopilot may apply unattended (the cap cuts, the send-gap widen, the campaign limit matches, and the unsubscribe header), with a test pinning the boundary so nothing that halts sending or generates new outbound mail can drift into it * feat: add advisor autopilot, which applies the auto-safe fixes unattended as the member who switched it on, resolving their live permissions each run so it fails closed when they leave the org, bounded to 10 changes per evaluation and audited per fix like any hand-made change * feat: add the advisor agent fix, a bounded per-finding agent run that resolves the problems a settings change cannot (broken template syntax, bulk-reading copy, shared-inbox lists) as the calling member inside a tool allowlist scoped to the finding's category, metered per iteration and marked applied only when it actually called a write tool * feat: surface autopilot and the agent fix in the dashboard, adding the workspace toggle that names exactly which changes it may make, an Auto chip on the findings it is allowed to take, and an agent-fix path in the resolution drawer that reports the tools it actually called rather than only its own account of them * docs: document the agent fix and autopilot, naming the exact set of changes autopilot may make, that it acts as the member who enabled it and stops when they leave, and why the agent-fix endpoint is JWT only * fix: gate the agent fix per detector instead of per category, so a missing DMARC record no longer offers a Fix-with-agent button it can never satisfy and then reports failure; findings whose fix lives in DNS or a provider console now show their manual steps, and the client is told which is which via agent_fixable * feat: soften the advisor surfaces to translucent washes, replacing the filled nav badge with a tinted pill that carries its colour in the text, frosting the row panel and the resolution drawer, and turning the severity chips and cards into layers the page shows through * docs: correct the agent-fix scope to name the findings it cannot resolve, and why a DNS record shows steps instead of a button * feat: ship the actual DNS records for the findings that live outside the platform, with the provider's SPF include resolved, the DMARC record scoped to the sending domain and starting at p=none, the DKIM host plus the console that generates its value, and a tracking CNAME pointing at this install's own tracking host * feat: render advisor snippets as labelled copy-button rows so a DNS record is one click per field rather than a text-selection exercise, with no copy affordance on a value the server could not supply * docs: document the pasteable DNS records and the guarantee that every check offers a fix, an agent, or ordered steps * fix: bump golang.org/x/text to 0.39.0 to clear CVE-2026-56852, a HIGH-severity infinite loop in norm.Iter that Trivy started failing the security scan on
172 lines
6.4 KiB
Go
172 lines
6.4 KiB
Go
package aitools
|
|
|
|
import (
|
|
"context"
|
|
"encoding/json"
|
|
"errors"
|
|
|
|
"github.com/google/uuid"
|
|
|
|
"github.com/warmbly/warmbly/internal/app/analytics"
|
|
"github.com/warmbly/warmbly/internal/app/apikey"
|
|
"github.com/warmbly/warmbly/internal/app/audit"
|
|
"github.com/warmbly/warmbly/internal/app/campaign"
|
|
"github.com/warmbly/warmbly/internal/app/compose"
|
|
"github.com/warmbly/warmbly/internal/app/contact"
|
|
"github.com/warmbly/warmbly/internal/app/crm"
|
|
"github.com/warmbly/warmbly/internal/app/email"
|
|
"github.com/warmbly/warmbly/internal/app/emailsend"
|
|
"github.com/warmbly/warmbly/internal/app/feature"
|
|
"github.com/warmbly/warmbly/internal/app/integration"
|
|
"github.com/warmbly/warmbly/internal/app/organization"
|
|
"github.com/warmbly/warmbly/internal/app/sequence"
|
|
"github.com/warmbly/warmbly/internal/app/subscription"
|
|
"github.com/warmbly/warmbly/internal/app/unibox"
|
|
"github.com/warmbly/warmbly/internal/app/warmup"
|
|
"github.com/warmbly/warmbly/internal/app/webhook"
|
|
"github.com/warmbly/warmbly/internal/errx"
|
|
"github.com/warmbly/warmbly/internal/infrastructure/cache"
|
|
"github.com/warmbly/warmbly/internal/models"
|
|
"github.com/warmbly/warmbly/internal/pkg/generation"
|
|
)
|
|
|
|
// Deps are the SERVICE-LAYER dependencies the tool handlers close over. Every
|
|
// handler calls one of these exactly as the matching HTTP handler would, so a
|
|
// tool never bypasses business rules, validation, or org scoping.
|
|
type Deps struct {
|
|
Contacts contact.ContactService
|
|
CRM crm.CRMService
|
|
Campaigns campaign.CampaignService
|
|
Analytics analytics.AnalyticsService
|
|
Unibox unibox.UniboxService
|
|
Automations integration.Service
|
|
Audit audit.AuditService
|
|
Search generation.SearchClient
|
|
Cache *cache.Cache
|
|
// Emails / EmailSend / Compose / Warmup back the mailbox-management and
|
|
// unified-inbox send tools. EmailSend is the only path that transmits mail
|
|
// to a real recipient (its tools are RiskSend).
|
|
Emails email.EmailService
|
|
EmailSend emailsend.EmailSendService
|
|
Compose compose.Service
|
|
Warmup warmup.Service
|
|
// Sequences backs the campaign-step (sequence node) tools.
|
|
Sequences sequence.SequenceService
|
|
// Org backs the team, invitation, and org-settings tools (JWT-only: these
|
|
// HTTP routes have no API-key permission bit).
|
|
Org organization.OrganizationService
|
|
// APIKeys / Webhooks back the developer-surface management tools.
|
|
APIKeys apikey.APIKeyService
|
|
Webhooks webhook.Service
|
|
// Subscription backs the read-only billing tools (JWT-only).
|
|
Subscription subscription.SubscriptionService
|
|
// Advanced is the suppression checker mirroring the compose handler's guard
|
|
// (a bounced/complained/unsubscribed recipient is unreachable). Optional; a
|
|
// nil checker skips the pre-send suppression gate.
|
|
Advanced SuppressionChecker
|
|
// FeatureGate applies the same subscription entitlement checks the HTTP
|
|
// handlers do (e.g. unibox requires an active trial/paid plan), so a tool
|
|
// can never read data a 403'd HTTP route would refuse.
|
|
FeatureGate feature.FeatureGateService
|
|
// Skills backs the load_skill tool (org playbooks). Optional.
|
|
Skills SkillLookup
|
|
// Advisor backs the read-only recommendation tools, so the assistant can
|
|
// ground an answer in what the Advisor has already diagnosed rather than
|
|
// re-deriving it from raw stats. Optional.
|
|
Advisor AdvisorReader
|
|
// AppBaseURL is the dashboard origin used to build deep links in draft
|
|
// artifacts (e.g. https://app.warmbly.com). Empty falls back to a relative
|
|
// path.
|
|
AppBaseURL string
|
|
}
|
|
|
|
// SuppressionChecker reports whether a recipient address is suppressed org-wide
|
|
// (bounced, complained, or unsubscribed). *advanced.service satisfies it. Kept
|
|
// as a local interface so aitools does not import the advanced package.
|
|
type SuppressionChecker interface {
|
|
ShouldSuppressRecipient(ctx context.Context, orgID uuid.UUID, recipient string) (bool, string, *errx.Error)
|
|
}
|
|
|
|
// SkillLookup returns an enabled org playbook's full content by name (backs the
|
|
// load_skill tool). *skills.service satisfies it.
|
|
type SkillLookup interface {
|
|
GetByName(ctx context.Context, orgID uuid.UUID, name string) (*models.AISkill, error)
|
|
}
|
|
|
|
// BuildRegistry constructs the registry with every initial tool registered.
|
|
// Called once at startup; the returned registry is queried per invocation.
|
|
func BuildRegistry(d Deps) *Registry {
|
|
r := NewRegistry()
|
|
d.registerContactTools(r)
|
|
d.registerCRMTools(r)
|
|
d.registerCampaignTools(r)
|
|
d.registerSequenceTools(r)
|
|
d.registerAnalyticsTools(r)
|
|
d.registerUniboxTools(r)
|
|
d.registerInboxActionTools(r)
|
|
d.registerInboxSendTools(r)
|
|
d.registerMailboxTools(r)
|
|
d.registerAutomationTools(r)
|
|
d.registerTeamTools(r)
|
|
d.registerSettingsTools(r)
|
|
d.registerBillingTools(r)
|
|
d.registerAPIKeyTools(r)
|
|
d.registerWebhookTools(r)
|
|
d.registerWebTools(r)
|
|
d.registerSkillTools(r)
|
|
// Advisor tools are registered separately, after the advisor service is
|
|
// constructed against this registry (see aitools.RegisterAdvisorTools).
|
|
return r
|
|
}
|
|
|
|
// logAudit fires an AUDIT_CREATED event via the normal audit path so the
|
|
// dashboard spine refreshes for every teammate after a write-class tool runs.
|
|
func (d Deps) logAudit(ctx context.Context, inv Invocation, action models.AuditAction, entity models.AuditEntityType, entityID *uuid.UUID, meta map[string]string) {
|
|
if d.Audit != nil {
|
|
d.Audit.LogAction(ctx, inv.OrgID, inv.UserID, action, entity, entityID, inv.IP, inv.UserAgent, nil, meta)
|
|
}
|
|
}
|
|
|
|
// --- shared helpers ---
|
|
|
|
// decodeArgs unmarshals the model's tool arguments into T, mapping a decode
|
|
// failure to ErrInvalidArgs (fed back to the model so it can correct itself).
|
|
func decodeArgs[T any](args json.RawMessage) (T, error) {
|
|
var v T
|
|
if len(args) == 0 {
|
|
return v, nil
|
|
}
|
|
if err := json.Unmarshal(args, &v); err != nil {
|
|
return v, ErrInvalidArgs
|
|
}
|
|
return v, nil
|
|
}
|
|
|
|
// jsonResult marshals a tool result to the compact JSON string fed to the model.
|
|
func jsonResult(v any) (string, error) {
|
|
b, err := json.Marshal(v)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
return string(b), nil
|
|
}
|
|
|
|
// fromErrx converts a service *errx.Error into a plain error for the tool
|
|
// result (nil stays nil). Only the human-readable message is surfaced.
|
|
func fromErrx(xerr *errx.Error) error {
|
|
if xerr == nil {
|
|
return nil
|
|
}
|
|
return errors.New(xerr.Message)
|
|
}
|
|
|
|
// parseUUIDArg parses a required UUID argument, returning ErrInvalidArgs on a
|
|
// bad/empty value.
|
|
func parseUUIDArg(s string) (uuid.UUID, error) {
|
|
id, err := uuid.Parse(s)
|
|
if err != nil {
|
|
return uuid.Nil, ErrInvalidArgs
|
|
}
|
|
return id, nil
|
|
}
|